Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: use v1beta1 in operator logic #527

Closed
wants to merge 12 commits into from

Conversation

odubajDT
Copy link
Contributor

This PR

  • adds this new feature

Related Issues

Fixes #352

Notes

Follow-up Tasks

How to test

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #527 (e0e638b) into main (32ddf00) will decrease coverage by 1.23%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
- Coverage   82.78%   81.55%   -1.23%     
==========================================
  Files          22        7      -15     
  Lines        1423      808     -615     
==========================================
- Hits         1178      659     -519     
+ Misses        207      120      -87     
+ Partials       38       29       -9     
Files Coverage Δ
common/common.go 100.00% <100.00%> (ø)
common/flagd-proxy.go 82.18% <100.00%> (ø)
common/utils/utils.go 52.38% <ø> (ø)
webhooks/common.go 100.00% <100.00%> (ø)
...rollers/core/flagsourceconfiguration/controller.go 46.37% <50.00%> (ø)
common/flagd-injector.go 90.22% <82.35%> (ø)
webhooks/pod_webhook.go 75.00% <77.27%> (-14.64%) ⬇️

... and 5 files with indirect coverage changes

Flag Coverage Δ
unit-tests 81.55% <88.46%> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@toddbaert
Copy link
Member

I guess we can close this in favor of: #539?

@odubajDT
Copy link
Contributor Author

Sure!

@odubajDT odubajDT closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[research] Consider moving CRDs to beta, and making beta "hub" versions
2 participants