Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce v1beta1 API version #535

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Oct 25, 2023

This PR

  • adds v1beta1 API version with new resources
  • adds E2E tests to check that new resources can be applied to cluster

Related Issues

Fixes #529

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #535 (9118a6c) into main (32ddf00) will increase coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
+ Coverage   82.78%   82.81%   +0.02%     
==========================================
  Files          22       24       +2     
  Lines        1423     1437      +14     
==========================================
+ Hits         1178     1190      +12     
- Misses        207      209       +2     
  Partials       38       38              
Files Coverage Δ
apis/core/v1beta1/featureflag_types.go 100.00% <100.00%> (ø)
apis/core/v1beta1/featureflagsource_types.go 83.33% <83.33%> (ø)
Flag Coverage Δ
unit-tests 82.81% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT marked this pull request as ready for review October 25, 2023 06:42
@odubajDT odubajDT requested a review from a team as a code owner October 25, 2023 06:42
@toddbaert
Copy link
Member

Thanks @odubajDT . I will give this a thorough review and test in the next few days.

PROJECT Show resolved Hide resolved
PROJECT Outdated Show resolved Hide resolved
@Kavindu-Dodan
Copy link
Contributor

Nice work. I left few comments but this IMO is important as we always try to validate flag configurations against the schema.

@toddbaert
Copy link
Member

I'm ready to approve once this is adapted as in #352 (comment)

PROJECT Outdated Show resolved Hide resolved
apis/core/v1beta1/featureflag_types.go Show resolved Hide resolved
apis/core/v1beta1/featureflag_types.go Show resolved Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
Copy link
Contributor Author

odubajDT commented Nov 2, 2023

@toddbaert @Kavindu-Dodan @beeme1mr PR adapted according to the discussion in #352

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I noticed this (just a question).

Also I'm noticing a lint error in the CI which almost make it seems like a dependency might require a higher go version or something: https://github.com/open-feature/open-feature-operator/actions/runs/6730203336/job/18292441905?pr=535#step:6:493

@odubajDT
Copy link
Contributor Author

odubajDT commented Nov 5, 2023

Approved, but I noticed this (just a question).

Also I'm noticing a lint error in the CI which almost make it seems like a dependency might require a higher go version or something: https://github.com/open-feature/open-feature-operator/actions/runs/6730203336/job/18292441905?pr=535#step:6:493

Thank you!

The error is present also in the main branch and is not related to this PR. I would say it should be resolved in a separate PR. I can have a look at it.

@Kavindu-Dodan
Copy link
Contributor

Approved, but I noticed this (just a question).
Also I'm noticing a lint error in the CI which almost make it seems like a dependency might require a higher go version or something: https://github.com/open-feature/open-feature-operator/actions/runs/6730203336/job/18292441905?pr=535#step:6:493

Thank you!

The error is present also in the main branch and is not related to this PR. I would say it should be resolved in a separate PR. I can have a look at it.

The error comes with the usage of golangci-lint@latest - From version v1.54.2 onwards, there's a transitive dependency which require Go version 1.20.x+ .

The quick fix for this PR is to fix makefile to v1.54.1 : https://github.com/open-feature/open-feature-operator/blob/main/Makefile#L88-L89

@odubajDT
Copy link
Contributor Author

odubajDT commented Nov 7, 2023

Approved, but I noticed this (just a question).
Also I'm noticing a lint error in the CI which almost make it seems like a dependency might require a higher go version or something: https://github.com/open-feature/open-feature-operator/actions/runs/6730203336/job/18292441905?pr=535#step:6:493

Thank you!
The error is present also in the main branch and is not related to this PR. I would say it should be resolved in a separate PR. I can have a look at it.

The error comes with the usage of golangci-lint@latest - From version v1.54.2 onwards, there's a transitive dependency which require Go version 1.20.x+ .

The quick fix for this PR is to fix makefile to v1.54.1 : https://github.com/open-feature/open-feature-operator/blob/main/Makefile#L88-L89

I already started working on a proper fix by moving the check to a separate workflow and also using a dedicated golangci-lint action for it #538

Hopefully it will be ready soon

@odubajDT odubajDT merged commit 3acd492 into open-feature:main Nov 7, 2023
11 of 12 checks passed
This was referenced Nov 15, 2023
This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce v1beta1 API version
5 participants