Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use github-action for golangci-lint workflow #538

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 6, 2023

This PR

  • move golangci-lint check to a separate workflow
  • set ubuntu version in workflows to stable one
  • fixes some of the linter issues
  • ignores some of the linter issues

Notes

The reason why some of the linter issues are ignored is the awaited huge refactoring/changes in the code planned as part of this and this ticket. Most of the functions/files affected by lint ignorers will be changed and adapted, so there is no reason to fix them now. The fixing of the linter issues (for now ignored by //nolint comments) are part of the mentioned issues (see AC)

@odubajDT odubajDT changed the title chore(deps): update actions/setup-node action to v4.0.0 chore: fix failing linter Nov 6, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #538 (b0971c5) into main (3acd492) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   82.81%   82.81%           
=======================================
  Files          24       24           
  Lines        1437     1437           
=======================================
  Hits         1190     1190           
  Misses        209      209           
  Partials       38       38           
Files Coverage Δ
...pis/core/v1alpha1/flagsourceconfiguration_types.go 97.09% <ø> (ø)
controllers/common/common.go 100.00% <ø> (ø)
controllers/common/flagd-injector.go 91.04% <ø> (ø)
...ollers/core/featureflagconfiguration/controller.go 54.63% <ø> (ø)
...rollers/core/flagsourceconfiguration/controller.go 46.37% <ø> (ø)
webhooks/featureflagconfiguration_webhook.go 68.75% <ø> (ø)
webhooks/pod_webhook.go 89.63% <ø> (ø)
webhooks/pod_webhook_deprecated.go 54.76% <ø> (ø)
Flag Coverage Δ
unit-tests 82.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT changed the title chore: fix failing linter chore: move golangci-lint workflow to a separate action Nov 7, 2023
@odubajDT odubajDT marked this pull request as ready for review November 7, 2023 07:55
@odubajDT odubajDT requested a review from a team as a code owner November 7, 2023 07:55
@odubajDT odubajDT changed the title chore: move golangci-lint workflow to a separate action chore: use github-action for golangci-lint workflow Nov 7, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT merged commit a97d336 into open-feature:main Nov 8, 2023
13 checks passed
This was referenced Nov 15, 2023
This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants