Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release APIs and Operator independently #541

Merged
merged 15 commits into from
Nov 15, 2023

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Nov 14, 2023

You can see the tags created in my fork here: https://github.com/thisthat/open-feature-operator/tags

For the Operator, the release works as previously creating containers and publishing them to a registry: https://github.com/thisthat/open-feature-operator/actions/runs/6861654249

For the APIs, only a tag is created: https://github.com/thisthat/open-feature-operator/actions/runs/6861600403

This PR covers only the release process. We should also move all go files into two different go modules.
This entails the following:

  1. Creating a go.mod file under the apis folder
  2. Remove dependency from utils in the new apis pkg (it is used in alpha1 and alpha2)

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
track API package release independently
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
track API package release independently
@thisthat thisthat requested a review from a team as a code owner November 14, 2023 10:16
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@thisthat thisthat marked this pull request as draft November 14, 2023 10:18
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #541 (a31fb4d) into main (a97d336) will decrease coverage by 4.88%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   82.81%   77.94%   -4.88%     
==========================================
  Files          24       10      -14     
  Lines        1437     1020     -417     
==========================================
- Hits         1190      795     -395     
+ Misses        209      189      -20     
+ Partials       38       36       -2     

see 14 files with indirect coverage changes

Flag Coverage Δ
unit-tests 77.94% <ø> (-4.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -1,3 +1,4 @@
{
".": "0.2.36"
".": "0.2.36",
"apis": "0.2.36"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should decide what should be the first version of the APIs package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think same version as the current package makes sense...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will slightly change how the release process works. @toddbaert and I have dealt with this enough times that it shouldn't be an issue here.

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Comment on lines +23 to +25
"exclude-paths": [
"apis"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this was an option.

@toddbaert
Copy link
Member

I'm 100% on board with this.

@thisthat
Copy link
Member Author

Nice, then I'll work on this PR making it fully working ;)

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@thisthat
Copy link
Member Author

thisthat commented Nov 15, 2023

To continue with this PR, I would need a tag for the /apis package. @toddbaert maybe we can have a sync and add that manually for the first release of the APIs :)
Otherwise, we can use the local "replace" in the operator go.mod until we do the first official apis release and live with a failing docker build for a while.

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@thisthat thisthat marked this pull request as ready for review November 15, 2023 14:53
@toddbaert toddbaert merged commit 7b1af42 into open-feature:main Nov 15, 2023
7 of 9 checks passed
This was referenced Nov 15, 2023
This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants