Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: release APIs and Operator independently #541

Merged
merged 15 commits into from
Nov 15, 2023
Merged

feat: release APIs and Operator independently #541

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
01c15a4
track API package release independently
thisthat Nov 14, 2023
4035e59
Merge pull request #1 from thisthat/poc-release-multi-artifact
thisthat Nov 14, 2023
d888658
add debug info
thisthat Nov 14, 2023
a7ae90a
add debug info
thisthat Nov 14, 2023
0d6f0cb
add shell default
thisthat Nov 14, 2023
b9bc19d
Merge pull request #4 from thisthat/poc-release-multi-artifact
thisthat Nov 14, 2023
b19d30f
bump minor
thisthat Nov 14, 2023
1d464bb
Merge pull request #5 from thisthat/poc-release-multi-artifact
thisthat Nov 14, 2023
2b530e4
add tags
thisthat Nov 14, 2023
2efb990
add tag separator
thisthat Nov 14, 2023
b9f0ba6
create new APIS package
thisthat Nov 15, 2023
955fa41
use local pkg replace
thisthat Nov 15, 2023
6d6a647
pin dependency on same versions
thisthat Nov 15, 2023
45b098d
pin dependency on same versions
thisthat Nov 15, 2023
a31fb4d
use local replace
thisthat Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ env:
IMAGE_NAME: ${{ github.repository }}
GITHUB_PAGES_BRANCH: gh-pages

defaults:
run:
shell: bash

permissions:
contents: read

Expand All @@ -30,6 +34,7 @@ jobs:
command: manifest
token: ${{secrets.GITHUB_TOKEN}}
default-branch: main

outputs:
release_created: ${{ steps.release.outputs.release_created }}
release_tag_name: ${{ steps.release.outputs.tag_name }}
Expand Down
3 changes: 2 additions & 1 deletion .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
".": "0.2.36"
".": "0.2.36",
"apis": "0.2.36"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should decide what should be the first version of the APIs package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think same version as the current package makes sense...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will slightly change how the release process works. @toddbaert and I have dealt with this enough times that it shouldn't be an issue here.

}
127 changes: 72 additions & 55 deletions release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,28 @@
{
"bootstrap-sha": "7d099c7b72f9a7430581696218458eaee31fb0df",
"separate-pull-requests": true,
"pull-request-title-pattern": "chore: release${component} ${version}",
"last-release-sha": "e5445ae5f41c29a5a62503438d86dcddf2c59617",
"tag-separator": "/",
"packages": {
"apis": {
"release-type": "go",
"package-name": "apis",
"draft": false,
"prerelease": false,
"bump-minor-pre-major": true,
"bump-patch-for-minor-pre-major": true,
"extra-files": []
},
".": {
"release-type": "go",
"package-name": "operator",
"draft": false,
"prerelease": false,
"bump-minor-pre-major": true,
"bump-patch-for-minor-pre-major": true,
"exclude-paths": [
"apis"
],
Comment on lines +23 to +25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this was an option.

"extra-files": [
"README.md",
"chart/open-feature-operator/Chart.yaml",
Expand All @@ -14,62 +31,62 @@
"Makefile",
"docs/quick_start.md",
"docs/installation.md"
],
"changelog-sections": [
{
"type": "feat",
"section": "✨ New Features"
},
{
"type": "fix",
"section": "🐛 Bug Fixes"
},
{
"type": "chore",
"section": "🧹 Chore"
},
{
"type": "docs",
"section": "📚 Documentation"
},
{
"type": "perf",
"section": "🚀 Performance"
},
{
"type": "build",
"hidden": true,
"section": "🛠️ Build"
},
{
"type": "deps",
"section": "📦 Dependencies"
},
{
"type": "ci",
"hidden": true,
"section": "🚦 CI"
},
{
"type": "refactor",
"section": "🔄 Refactoring"
},
{
"type": "revert",
"section": "🔙 Reverts"
},
{
"type": "style",
"hidden": true,
"section": "🎨 Styling"
},
{
"type": "test",
"hidden": true,
"section": "🧪 Tests"
}
]
}
},
"changelog-sections": [
{
"type": "feat",
"section": "✨ New Features"
},
{
"type": "fix",
"section": "🐛 Bug Fixes"
},
{
"type": "chore",
"section": "🧹 Chore"
},
{
"type": "docs",
"section": "📚 Documentation"
},
{
"type": "perf",
"section": "🚀 Performance"
},
{
"type": "build",
"hidden": true,
"section": "🛠️ Build"
},
{
"type": "deps",
"section": "📦 Dependencies"
},
{
"type": "ci",
"hidden": true,
"section": "🚦 CI"
},
{
"type": "refactor",
"section": "🔄 Refactoring"
},
{
"type": "revert",
"section": "🔙 Reverts"
},
{
"type": "style",
"hidden": true,
"section": "🎨 Styling"
},
{
"type": "test",
"hidden": true,
"section": "🧪 Tests"
}
],
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}
Loading