chore: adapt API for sidecar image and tag restriction #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
==========================================
- Coverage 84.23% 83.03% -1.21%
==========================================
Files 10 10
Lines 1015 943 -72
==========================================
- Hits 855 783 -72
Misses 130 130
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
approved these changes
Nov 17, 2023
thisthat
approved these changes
Nov 17, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #517
Preparation for #550
Details
To restrict the setup of the sidecar image and tag, we need to remove the image and tag parameters from FFS CRD. These values will be read from the env variables of the operator deployment. Also the reading of the env variables should not happen in the CRD struct function, but should be handled in a common place for all env variable, for example in the
main.go. Please see the linked PR for more details