Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor code to decrease complexity #554

Merged
merged 8 commits into from
Nov 22, 2023

Update common/types/envconfig.go

09ae2ee
Select commit
Loading
Failed to load commit list.
Merged

chore: refactor code to decrease complexity #554

Update common/types/envconfig.go
09ae2ee
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 22, 2023 in 0s

87.91% (+3.63%) compared to ccc0471

View this Pull Request on Codecov

87.91% (+3.63%) compared to ccc0471

Details

Codecov Report

Merging #554 (09ae2ee) into main (ccc0471) will increase coverage by 3.63%.
The diff coverage is 94.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
+ Coverage   84.27%   87.91%   +3.63%     
==========================================
  Files          10       10              
  Lines         935      927       -8     
==========================================
+ Hits          788      815      +27     
+ Misses        121       89      -32     
+ Partials       26       23       -3     
Files Coverage Δ
apis/core/v1beta1/featureflagsource_types.go 96.59% <100.00%> (ø)
common/common.go 100.00% <ø> (ø)
common/flagdproxy/flagdproxy.go 86.98% <100.00%> (+2.05%) ⬆️
common/utils/utils.go 100.00% <ø> (+61.90%) ⬆️
webhooks/common.go 100.00% <100.00%> (ø)
webhooks/pod_webhook.go 85.85% <100.00%> (ø)
controllers/core/featureflagsource/controller.go 51.31% <83.33%> (+4.93%) ⬆️
common/flagdinjector/flagdinjector.go 92.06% <94.91%> (+1.83%) ⬆️