Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed client metaprogramming to send with real methods #154

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxveldink
Copy link
Member

This PR

  • adds this new feature

Related Issues

Fixes #1234523

Notes

Follow-up Tasks

How to test

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.75%. Comparing base (3ca368d) to head (aa098db).

Files with missing lines Patch % Lines
lib/open_feature/sdk/client.rb 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   99.54%   98.75%   -0.79%     
==========================================
  Files          16       16              
  Lines         218      241      +23     
==========================================
+ Hits          217      238      +21     
- Misses          1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Max VelDink <maxveldink@gmail.com>
@maxveldink maxveldink force-pushed the mv/remove-metaprogramming-in-client branch from f10b565 to aa098db Compare October 2, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant