Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codecov integration #59

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

mschoenlaub
Copy link
Contributor

This PR

  • adds code coverage

Related Issues

This is a first step for fixing #54

Follow-up Tasks

  • Setting up the codecov project, I guess.

@technicalpickles
Copy link
Collaborator

Hm, looks like it's failing because of the missing Gem. That should be added to Gemfile.

It also looks like this is including commits from #58

Signed-off-by: Manuel Schönlaub <manuel.schoenlaub@gmail.com>
@codecov
Copy link

codecov bot commented Sep 9, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@mschoenlaub
Copy link
Contributor Author

@technicalpickles Yep, noticed that too. It's fixed now, thanks 🙇

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@toddbaert toddbaert merged commit 4cbcf97 into open-feature:main Sep 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants