Remove the low-level fallback handling #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
commented
Aug 15, 2024
FallbackSchema (i.e. unknown component types) need to be handled as soon as possible, since they make it harder to operate in type-safe ways on downstream components. Being able to reason only in AnyCompnentSchema simplifies implementations and guard clauses.
sergei-maertens
force-pushed
the
chore/remove-fallback-types
branch
from
7a2074d to
d76a52e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit overdue now, so clearing this up as I noticed I was starting to bump into it with the form preview.
The situation is:
It's important that the application doesn't crash when such an unsupported component is present, but the challenge is that we don't know what it looks like. So, for that,
FallbackSchemaexists.In the public API entrypoints, we must allow for
AnyComponentSchemaandFallbackSchema, so that our type checker helps us in preventing crashes. This was and remains the case.This PR instead moves all the fallback handling from the internal/private API, as we are feature complete in terms of supported components and don't need this anymore. This should simplify the code/maintenance quite a bit.