Add background image configuration to map component #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on a change in the type library. Keeping this as draft, until those have been added |
robinmolen
force-pushed
the
feature/2173-map-background-configuration
branch
from
92918cd to
9dda5d2
Compare
robinmolen
requested review from
vaszig
and removed request for
sergei-maertens
vaszig
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
I don't see something weird. I didn't manage though to test this manually (tried with npm pack and then installed it in the backend) so I guess @sergei-maertens has to do another review here.
sergei-maertens
requested changes
Dec 5, 2024
robinmolen
force-pushed
the
feature/2173-map-background-configuration
branch
from
9dda5d2 to
f332bca
Compare
sergei-maertens
requested changes
Dec 6, 2024
src/context.ts
Outdated
| @@ -48,6 +59,7 @@ export interface BuilderContextType { | |||
| getDocumentTypes: () => Promise<Array<DocumentTypeOption>>; | |||
| getConfidentialityLevels: () => Promise<SelectOption[]>; | |||
| getAuthPlugins: () => Promise<AuthPluginOption[]>; | |||
| getMapTileLayers: () => Promise<MapTileLayers[]>; | |||
There was a problem hiding this comment.
Suggested change
| getMapTileLayers: () => Promise<MapTileLayers[]>; | |
| getMapTileLayers: () => Promise<MapTileLayer[]>; |
robinmolen
force-pushed
the
feature/2173-map-background-configuration
branch
from
f332bca to
0c13e8b
Compare
9 tasks
| }, | ||
| modal: {noModal: true}, | ||
| }, | ||
| } as Meta<typeof Loader>; |
There was a problem hiding this comment.
Suggested change
| } as Meta<typeof Loader>; | |
| } satisfies Meta<typeof Loader>; |
this should be preferred since it doesn't just cast the type, it performs the proper type checks still :)
There was a problem hiding this comment.
Ah okay cool! Yeah that sounds a lot better 👌
robinmolen
force-pushed
the
feature/2173-map-background-configuration
branch
from
0c13e8b to
7013ba4
Compare
sergei-maertens
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-formulieren/open-forms#2173
The map component now has background configuration. This changes the image which is used for the leaflet tile layer (the background of the map component)