👌 [open-formulieren/open-forms#4929] PR feedback

open-formulieren · Jan 21, 2025 · 49c9615 · 49c9615
1 parent 161f4aa
commit 49c9615
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/src/components/AbortButton/AbortButton.jsx b/src/components/AbortButton/AbortButton.jsx
@@ -8,7 +8,7 @@ import useFormContext from 'hooks/useFormContext';
 
 const AbortButton = ({isAuthenticated, onDestroySession}) => {
   const intl = useIntl();
-  const analyticsToolsConfig = useAnalyticsToolsConfig;
+  const analyticsToolsConfig = useAnalyticsToolsConfig();
   const form = useFormContext();
 
   const confirmationMessage = isAuthenticated

diff --git a/src/components/Form.spec.jsx b/src/components/Form.spec.jsx
@@ -232,7 +232,7 @@ test('Submitting the form with successful background processing', async () => {
   vi.useRealTimers();
   await waitForElementToBeRemoved(loader);
 
-  // due to the error we get redirected back to the summary page.
+  // on success, the summary page must display the reference obtained from the backend
   expect(await screen.findByRole('heading', {name: 'Confirmation: OF-L337'})).toBeVisible();
 });
 

diff --git a/src/components/PostCompletionViews/StatusUrlPoller.jsx b/src/components/PostCompletionViews/StatusUrlPoller.jsx
@@ -49,7 +49,6 @@ const StatusUrlPoller = ({statusUrl, onFailureNavigateTo, onConfirmed, children}
       }
     }
   );
-  if (error) throw error;
 
   if (loading) {
     return (
@@ -79,7 +78,6 @@ const StatusUrlPoller = ({statusUrl, onFailureNavigateTo, onConfirmed, children}
   if (error) throw error;
 
   const {
-    result,
     paymentUrl,
     publicReference,
     reportDownloadUrl,
@@ -88,10 +86,6 @@ const StatusUrlPoller = ({statusUrl, onFailureNavigateTo, onConfirmed, children}
     mainWebsiteUrl,
   } = statusResponse;
 
-  if (result === RESULT_FAILED) {
-    throw new Error('Failure should have been handled in the onFailure prop.');
-  }
-
   return (
     <SubmissionStatusContext.Provider
       value={{

diff --git a/src/components/analytics/AnalyticsToolConfigProvider.jsx b/src/components/analytics/AnalyticsToolConfigProvider.jsx
@@ -22,7 +22,7 @@ const AnalyticsToolsConfigProvider = ({children}) => {
 
   const {value} = useAsync(async () => {
     return await get(`${baseUrl}analytics/analytics-tools-config-info`);
-  }, [locale]);
+  }, [baseUrl, locale]);
 
   return (
     <AnalyticsToolsConfigContext.Provider value={value}>