⚰️ [open-formulieren/open-forms#4929] Remove onFailure prop

It's no longer necessary.
open-formulieren · Jan 17, 2025 · f5da831 · f5da831
1 parent 537d743
commit f5da831
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/src/components/PostCompletionViews/ConfirmationView.jsx b/src/components/PostCompletionViews/ConfirmationView.jsx
@@ -107,7 +107,7 @@ ConfirmationViewDisplay.propTypes = {
   downloadPDFText: PropTypes.node,
 };
 
-const ConfirmationView = ({returnTo, onFailure, onConfirmed}) => {
+const ConfirmationView = ({returnTo, onConfirmed}) => {
   const form = useFormContext();
   // TODO: take statusUrl from session storage instead of router state / query params,
   // which is the best tradeoff between security and convenience (state doesn't survive
@@ -127,7 +127,6 @@ const ConfirmationView = ({returnTo, onFailure, onConfirmed}) => {
     <StatusUrlPoller
       statusUrl={statusUrl}
       onFailure={error => {
-        onFailure?.(error);
         if (returnTo) {
           const newState = {...(location.state || {}), errorMessage: error};
           navigate(returnTo, {state: newState});
@@ -145,11 +144,6 @@ ConfirmationView.propTypes = {
    * Location to navigate to on failure.
    */
   returnTo: PropTypes.string,
-  /**
-   * Optional callback to invoke when processing failed.
-   * @deprecated
-   */
-  onFailure: PropTypes.func,
   /**
    * Optional callback to invoke when processing was successful.
    * @deprecated

diff --git a/src/components/PostCompletionViews/StartPaymentView.jsx b/src/components/PostCompletionViews/StartPaymentView.jsx
@@ -61,7 +61,7 @@ StartPaymentViewDisplay.propTypes = {
   downloadPDFText: PropTypes.node,
 };
 
-const StartPaymentView = ({returnTo, onFailure}) => {
+const StartPaymentView = ({returnTo}) => {
   const form = useFormContext();
   const navigate = useNavigate();
   const {statusUrl} = useLocation().state || {};
@@ -70,7 +70,6 @@ const StartPaymentView = ({returnTo, onFailure}) => {
     <StatusUrlPoller
       statusUrl={statusUrl}
       onFailure={error => {
-        onFailure(error);
         if (returnTo) {
           const newState = {...(location.state || {}), errorMessage: error};
           navigate(returnTo, {state: newState});
@@ -87,11 +86,6 @@ StartPaymentView.propTypes = {
    * Location to navigate to on failure.
    */
   returnTo: PropTypes.string,
-  /**
-   * Optional callback to invoke when processing failed.
-   * @deprecated
-   */
-  onFailure: PropTypes.func,
 };
 
 export default StartPaymentView;