Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [open-formulieren/open-forms#2952] Support form steps to be N/A by default #575

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Oct 25, 2023

Fixes open-formulieren/open-forms#2952
Part of open-formulieren/open-forms#3551

Tests were refactored to use testing-library where possible (i.e. when using aria roles was possible)

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2787793) 70.87% compared to head (109e2ae) 70.76%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
- Coverage   70.87%   70.76%   -0.12%     
==========================================
  Files         209      210       +1     
  Lines        4306     4324      +18     
  Branches     1164     1174      +10     
==========================================
+ Hits         3052     3060       +8     
- Misses       1219     1228       +9     
- Partials       35       36       +1     
Files Coverage Δ
src/components/ProgressIndicator/index.js 86.53% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit 32a8ca0 into main Oct 27, 2023
11 of 12 checks passed
@sergei-maertens sergei-maertens deleted the feature/form-step-na-default branch October 27, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow steps to become applicable (reverse n/a)
3 participants