Skip to content

Commit

Permalink
Merge pull request #4938 from open-formulieren/fix/4832-uri-attribute…
Browse files Browse the repository at this point in the history
…s-cannot-be-selected-in-the-pfdurl-variable

[#4832] Fix json schema matcher in Objects API
  • Loading branch information
vaszig authored Dec 18, 2024
2 parents 738be59 + 6017166 commit 0456eb1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/openforms/contrib/objects_api/json_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ def json_schema_matches(
if "string" in target_types and (target_format := target_schema.get("format")):
variable_format = variable_schema.get("format")
if variable_format is None:
return False
return True
return variable_format == target_format

return True
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ def test_json_schema_matches(self):
variable_schema = {"type": "string"}
target_schema = {"type": "string", "format": "email"}

self.assertFalse(
self.assertTrue(
json_schema_matches(
variable_schema=variable_schema, target_schema=target_schema
)
Expand Down

0 comments on commit 0456eb1

Please sign in to comment.