Merge pull request #4987 from open-formulieren/issue/4978-fix-escaped…

…-html-in-pdf

🐛 [#4978] Fix accidental HTML escaping in summary PDF/confirmatio…

src/openforms/emails/tests/test_confirmation_email.py

@@ -227,9 +227,7 @@ def test_attachment(self):
         self.assertTagWithTextIn("td", "Last name", rendered_content)
         self.assertTagWithTextIn("td", "Doe", rendered_content)
         self.assertTagWithTextIn("td", "File", rendered_content)
-        self.assertTagWithTextIn(
-            "td", _("attachment: %s") % "my-image.jpg", rendered_content
-        )
+        self.assertTagWithTextIn("td", "my-image.jpg", rendered_content)
 
     @patch(
         "openforms.emails.templatetags.appointments.get_plugin",

src/openforms/formio/formatters/formio.py

@@ -81,10 +81,14 @@ def normalise_value_to_list(self, component: Component, value: Any):
             return value
 
     def process_result(self, component: Component, formatted: str) -> str:
-        # prefix joined filenames to match legacy
-        if formatted:
+        if not formatted:
+            return ""
+
+        # Make sure we don't mangle safe-strings!
+        if self.as_html:
+            return formatted
+        else:
             return _("attachment: %s") % formatted
-        return formatted
 
     def format(self, component: Component, value: dict) -> str:
         # this is only valid for display to the user (because filename component option, dedupe etc)