⏪️ Do not raise on property setter

open-formulieren · Oct 27, 2023 · badfe84 · badfe84
1 parent 0126143
commit badfe84
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/src/openforms/submissions/models/submission_step.py b/src/openforms/submissions/models/submission_step.py
@@ -202,8 +202,6 @@ def is_applicable(self) -> bool:
 
     @is_applicable.setter
     def is_applicable(self, value: bool) -> None:
-        if not isinstance(value, bool):
-            raise ValueError(f"'is_applicable' expects a boolean value, got {value}")
         self._is_applicable = value
 
     def reset(self):

diff --git a/src/openforms/submissions/tests/test_submission_steps_state.py b/src/openforms/submissions/tests/test_submission_steps_state.py
@@ -86,5 +86,3 @@ def test_step_set_applicable(self):
         self.assertTrue(submission_step.is_applicable)
         submission_step.is_applicable = False
         self.assertFalse(submission_step.is_applicable)
-        with self.assertRaises(ValueError):
-            submission_step.is_applicable = None