Skip to content

Commit

Permalink
📝 Document expired domain for test
Browse files Browse the repository at this point in the history
It's okay - we don't need to re-record this cassette anyway. As long as
'we verify that the WSDL can be parsed and used correctly, we're good.
  • Loading branch information
sergei-maertens committed Dec 20, 2024
1 parent f703de5 commit d3f2d51
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/prepare-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ assignees: sergei-maertens
- [ ] `openforms.contrib.haal_centraal.tests.test_integration`
- [ ] `openforms.contrib.kvk`
- [ ] `openforms.contrib.objects_api.tests`
- [ ] `soap.tests.test_client`
- `suwinet.tests.test_client` (testenv access has been retracted and won't be reinstated)
- Forms
- [ ] `openforms.forms.tests.test_import_export`
Expand Down
4 changes: 4 additions & 0 deletions src/soap/tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ def test_default_behaviour_relative_paths(self, m):
self.assertEqual(m.last_request.url, "https://example.com/api/relative")

def test_it_can_build_a_functional_client(self):
# NOTE - soapclient.com no longer exists so we can't re-record these
# cassettes. That's not a problem, as we mostly check that the WSDL processing
# works as expected and it's not a real service that we talk to that may break
# our application.
service = SoapServiceFactory.build(
url="http://www.soapclient.com/xml/soapresponder.wsdl"
)
Expand Down

0 comments on commit d3f2d51

Please sign in to comment.