Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations of checkboxes, radio & choice answers show as required when removed #4637

Closed
LaurensBurger opened this issue Sep 6, 2024 · 3 comments · Fixed by open-formulieren/formio-builder#180 or #4748
Closed

Translations of checkboxes, radio & choice answers show as required when removed #4637

LaurensBurger opened this issue Sep 6, 2024 · 3 comments · Fixed by open-formulieren/formio-builder#180 or #4748
Assignees
@robinmolen
Labels
bug Something isn't working
Milestone
Release 3.0

Comments

@LaurensBurger
Copy link
Collaborator

Product versie / Product version

2.7.x - latest

Customer reference

LV 195

Omschrijf het probleem / Describe the bug

Translations become required fields after saving them once, not allowing a form builder to remove the translations for the answers:
image

This does not seem to happen for other translations like labels, tooltips etc.

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Sep 6, 2024
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Sep 9, 2024
@joeribekker joeribekker added this to the Release 2.8.0 milestone Sep 9, 2024
@joeribekker
Copy link
Contributor

Refinement: Confirmed. It also happens with options for radio-options on latest.

@robinmolen
Copy link
Contributor

This issue will be resolved in the release after 2.8 (so probably release 3.0)

Until this issue is resolved, users can workaround this situation by defining option translations.

@robinmolen robinmolen linked a pull request Sep 23, 2024 that will close this issue
Issue/4637 optional translations act as required open-formulieren/formio-builder#180
Merged
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
✅ [open-formulieren/open-forms#4637] Fixed some storybook tests and p…
af766da 
…rettified code

🎨 [#4637] Prettified code

:white_check_mark: [#4637] Fixed some storybook test with waitFor

:fire: [#4637] Removed unnecessary awaits from storybook tests
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
🐛 [open-formulieren/open-forms#4637] Ensure value translations are op…
02fce61 
…tional

🐛 [#4637] Ensure values translations are optional

:rewind: [#4637] Revert validation change

The validation for `data.values[]` is already applied by `select/edit-validation.ts`. And isn't needed for `selectboxes/edit-validation.ts`.
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
✅ [open-formulieren/open-forms#4637] Fixed some storybook tests and p…
7d94e27 
…rettified code

🎨 [#4637] Prettified code

:white_check_mark: [#4637] Fixed some storybook test with waitFor

:fire: [#4637] Removed unnecessary awaits from storybook tests
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
🧪 [open-formulieren/open-forms#4637] added tests to validate option t…
b8c2117 
…ranslations

🧪 [#4637] added tests to validate option translations

:white-check-mark: [#4637] Fixed ComponentConfiguration test expectations
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
🐛 [open-formulieren/open-forms#4637] Ensure value translations are op…
47578b5 
…tional

🐛 [#4637] Ensure values translations are optional

:rewind: [#4637] Revert validation change

The validation for `data.values[]` is already applied by `select/edit-validation.ts`. And isn't needed for `selectboxes/edit-validation.ts`.
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
✅ [open-formulieren/open-forms#4637] Fixed some storybook tests and p…
6623aa9 
…rettified code

🎨 [#4637] Prettified code

:white_check_mark: [#4637] Fixed some storybook test with waitFor

:fire: [#4637] Removed unnecessary awaits from storybook tests
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
✅ [open-formulieren/open-forms#4637] Added translation tests to radio…
b2597b7 
…, select and selectboxes component tests
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
✅ [open-formulieren/open-forms#4637] Fixed some storybook tests and p…
883f5a6 
…rettified code

🎨 [#4637] Prettified code

:white_check_mark: [#4637] Fixed some storybook test with waitFor

:fire: [#4637] Removed unnecessary awaits from storybook tests
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
🧪 [open-formulieren/open-forms#4637] added tests to validate option t…
cf82e1e 
…ranslations
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
🐛 [open-formulieren/open-forms#4637] Ensure value translations are op…
1c748fa 
…tional
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
✅ [open-formulieren/open-forms#4637] Added translation tests to radio…
6d76da5 
…, select and selectboxes component tests
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Sep 24, 2024
@robinmolen
✅ [open-formulieren/open-forms#4637] Fixed some storybook tests and p…
3a98100 
…rettified code
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Oct 2, 2024
@robinmolen robinmolen reopened this Oct 2, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Development Oct 2, 2024
@sergei-maertens
Copy link
Member

note to self: depends on new formio-builder release

sergei-maertens added a commit that referenced this issue Oct 10, 2024
@sergei-maertens
⬆️ Upgrade to formio-builder 0.30
8c43d7d 
Closes #4636
Closes #4637

This also exposes the ProductPrice experimental component, which will
likely be gated behind a feature flag for the full 3.0 release.
@sergei-maertens sergei-maertens mentioned this issue Oct 10, 2024
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Oct 10, 2024
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
⬆️ Upgrade to formio-builder 0.30
b2e2436 
Closes #4636
Closes #4637

This also exposes the ProductPrice experimental component, which will
likely be gated behind a feature flag for the full 3.0 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
bug Something isn't working
Projects
Development
Archived in project
Milestone
Release 3.0
4 participants
@joeribekker @sergei-maertens @LaurensBurger @robinmolen