Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the email and StUF-ZDS inline forms #4686

Closed
robinmolen opened this issue Sep 19, 2024 · 0 comments · Fixed by #4742
Closed

Updating the email and StUF-ZDS inline forms #4686

robinmolen opened this issue Sep 19, 2024 · 0 comments · Fixed by #4742
Assignees
@robinmolen
Labels
enhancement owner: maykin

Comments

@robinmolen
Copy link
Contributor

Thema / Theme

Form designer

Omschrijving / Description

The inline forms for email and StUF-ZDS currently break with the design and use a different form builder (react-json-schema-form). See here: Storybook: Configured Backends

The inline forms should be moved to a modal, like the ZGW api and Object api configuration forms, and make use of Reactjs/Formik instead of react-json-schema-form. This ensures a consistent design and predicable functionality.

Added value / Toegevoegde waarde

Changing the forms frees us from the react-json-schema-form dependency, and helps to keep the UI consistent.

Aanvullende opmerkingen / Additional context

No response
@robinmolen robinmolen added enhancement triage Issue needs to be validated. Remove this label if the issue considered valid. labels Sep 19, 2024
@robinmolen robinmolen self-assigned this Sep 19, 2024
@robinmolen robinmolen changed the title Title here Updating the email and StUF-ZDS inline forms Sep 19, 2024
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Sep 23, 2024
robinmolen added a commit that referenced this issue Sep 24, 2024
@robinmolen
✨ [#4686] Replaced uiSchema with components for form backend registra…
aa72eac 
…tion - Email
robinmolen added a commit that referenced this issue Sep 24, 2024
@robinmolen
✨ [#4686] Replaced uiSchema with components for form backend registra…
2f00675 
…tion - StUF ZDS
robinmolen added a commit that referenced this issue Sep 24, 2024
@robinmolen
[#4686] Resolved todos
213bbdb
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
💄 [#4686] PaymentStatusUpdateMappingInputs component styling
5518447
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
💄 [#4686] PaymentStatusUpdateMapping field layout
e69ade4
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
💄 [#4686] PaymentStatusUpdateMappingInputs component styling
b18946f
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
💄 [#4686] PaymentStatusUpdateMapping component styling
f04f46c
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✅ [#4686] Added StUF-ZDS to storybook
c19c576
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✅ [#4686] StUF-ZDS schema config for storybook
ef56075
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
🌐 [#4686] Updated translations
7ab93ed
@robinmolen robinmolen mentioned this issue Sep 25, 2024
Closed
9 tasks
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✅ [#4686] Added StUF-ZDS to storybook
3a265c4
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
🌐 [#4686] Updated translations
abcd8bc
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
💄 [#4686] PaymentStatusUpdateMapping component styling
d880170
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✅ [#4686] Added StUF-ZDS to storybook
e61d332
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
🌐 [#4686] Updated translations
f3292dd
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✨ [#4686] Added custom registration form component for Email
c5d0103
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✨ [#4686] Added custom registration form component for StUF-ZDS
2542995
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
💄 [#4686] PaymentStatusUpdateMapping component styling
7dcd3c8
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✅ [#4686] Added StUF-ZDS to storybook
716a783
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
🌐 [#4686] Updated translations
209eb3c
robinmolen added a commit that referenced this issue Oct 2, 2024
@robinmolen
✨ [#4686] Added custom registration form component for Email
3794070
robinmolen added a commit that referenced this issue Oct 2, 2024
@robinmolen
✅ [#4686] Added StUF-ZDS to storybook
173cd78
robinmolen added a commit that referenced this issue Oct 2, 2024
@robinmolen
🌐 [#4686] Updated translations
e10cec9
robinmolen added a commit that referenced this issue Oct 8, 2024
@robinmolen
✨ [#4686] Added custom registration form component for Email
ec8569a
robinmolen added a commit that referenced this issue Oct 8, 2024
@robinmolen
✨ [#4686] Added custom registration form component for StUF-ZDS
d958460
robinmolen added a commit that referenced this issue Oct 8, 2024
@robinmolen
✅ [#4686] Added StUF-ZDS to storybook
7ba3965
robinmolen added a commit that referenced this issue Oct 8, 2024
@robinmolen
✨ [#4686] Added custom registration form component for StUF-ZDS
361c82e
robinmolen added a commit that referenced this issue Oct 8, 2024
@robinmolen
✅ [#4686] Added StUF-ZDS to storybook
7e635ab
robinmolen added a commit that referenced this issue Oct 8, 2024
@robinmolen
📝 [#4686] Added stories for email and StUF ZDS registration
29ef884
robinmolen added a commit that referenced this issue Oct 8, 2024
@robinmolen
🌐 [#4686] Updated translations
9c246fe
@robinmolen robinmolen mentioned this issue Oct 8, 2024
Merged
9 tasks
@robinmolen robinmolen linked a pull request Oct 8, 2024 that will close this issue
UX improvements: modal registration forms for email and stuf #4742
Merged
9 tasks
sergei-maertens pushed a commit that referenced this issue Oct 31, 2024
@robinmolen @sergei-maertens
✨ [#4686] Added custom registration form component for Email
c76dca5
sergei-maertens pushed a commit that referenced this issue Oct 31, 2024
@robinmolen @sergei-maertens
✨ [#4686] Added custom registration form component for StUF-ZDS
37e04be
sergei-maertens pushed a commit that referenced this issue Oct 31, 2024
@robinmolen @sergei-maertens
✅ [#4686] Added StUF-ZDS to storybook
0ac5ed0
sergei-maertens pushed a commit that referenced this issue Oct 31, 2024
@robinmolen @sergei-maertens
📝 [#4686] Added stories for email and StUF ZDS registration
c3f056e
sergei-maertens pushed a commit that referenced this issue Oct 31, 2024
@robinmolen @sergei-maertens
🌐 [#4686] Updated translations
7ab8561
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
🚸 [#4686] Logically group email registration options
3391695
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
🎨 [#4686] Workaround not being able to use null/undefined for a value…
2eab6b3 
… in react-select
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
🚸 [#4686] Ensure to-emails in config is never completely empty
f105c49 
Otherwise it would be too easy for form designers to miss the option,
let's make it clear that at least one email address must be entered.
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
⚰️ [#4686] Delete unused code
b125106
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
🚚 [#4686] Rename files/components to their correct StUF-ZDS terms
4fb83e9
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
🚸 [#4686] Put StUF-ZDS configuration in tabs
7d195ad 
Similar to the case properties, we can put the payment update mappings
in a separate tab to de-clutter the UI. Next commit will then use
the existing VariableMapping component to manage the actual mappings.
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
🚸 [#4686] Replace the StUF payment update mapping with a variable map…
9a350f4 
…ping

Some code repetition, but at least we are now using consistent UI
components for mapping from/to form variables in various places.
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
⚰️ [#4686] Delete obsoleted CSS
e8ad345
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
♻️ [#4686] Refactor duplicated code
c5a1a4d 
Created a generic component for the button-that-opens-modal with error
icon next to it, which renders the plugin-specific configuration form
inside. This puts the less elegant code in a nice isolated box instead
of spreading across the code base.
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
♻️ [#4686] De-duplicate utility code
2144f07
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
🎨 [#4686] Fix react uncontrolled -> controlled component warning and …
2eaa872 
…correct wrong texts
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Oct 31, 2024
@sergei-maertens sergei-maertens mentioned this issue Nov 27, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
enhancement owner: maykin
Projects
Development
Archived in project
Milestone
No milestone
3 participants
@joeribekker @sergei-maertens @robinmolen