Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system check for missing allow_blank=True in specific serializer fields #4927

Closed
vaszig opened this issue Dec 16, 2024 · 1 comment · Fixed by #4989
Closed

Add system check for missing allow_blank=True in specific serializer fields #4927

vaszig opened this issue Dec 16, 2024 · 1 comment · Fixed by #4989
Assignees
@stevenbal
Labels
enhancement owner: maykin
Milestone
Release 3.1.0

Comments

@vaszig
Copy link
Contributor

vaszig commented Dec 16, 2024

We have seen a lot these days (issues #4853 and #4899) that some serializer fields give an error when empty strings are being received from the frontend. It would be nice if we have a system check for this kind of problems and warn the developer about the potential error.
@vaszig vaszig added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Dec 16, 2024
@sergei-maertens sergei-maertens removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Jan 6, 2025
@sergei-maertens sergei-maertens added this to the Release 3.1.0 milestone Jan 6, 2025
@sergei-maertens
Copy link
Member

Estimate: 1 day

@stevenbal stevenbal moved this from Todo to In Progress in Development Jan 6, 2025
stevenbal added a commit that referenced this issue Jan 6, 2025
@stevenbal
🔊 [#4927] Add system check for missing allow_blank on non-required ch…
417fb86 
…arfields
stevenbal added a commit that referenced this issue Jan 6, 2025
@stevenbal
🚨 [#4927] Add missing allow_blank=True for several fields
8fa38e2
@stevenbal stevenbal mentioned this issue Jan 6, 2025
Merged
10 tasks
stevenbal added a commit that referenced this issue Jan 7, 2025
@stevenbal
🔊 [#4927] System check for missing allow_blank on non-required charfi…
ef4e665 
…elds

because in most cases it is desired to allow empty strings as well
stevenbal added a commit that referenced this issue Jan 7, 2025
@stevenbal
🚨 [#4927] Add missing allow_blank=True for several fields
ff6cc90
@stevenbal stevenbal moved this from In Progress to Done in Development Jan 9, 2025
@stevenbal stevenbal moved this from Done to Implemented in Development Jan 9, 2025
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🔊 [#4927] System check for missing allow_blank on non-required charfi…
e56665d 
…elds

because in most cases it is desired to allow empty strings as well
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🚨 [#4927] Add missing allow_blank=True for several fields
f7a6950
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🚨 [#4927] Add missing allow_blank=True for several fields
1657722
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🔊 [#4927] System check for missing allow_blank on non-required charfi…
fe753cb 
…elds

because in most cases it is desired to allow empty strings as well
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🚨 [#4927] Add missing allow_blank=True for several fields
c615fa9
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🔊 [#4927] System check for missing allow_blank on non-required charfi…
a8402a5 
…elds

because in most cases it is desired to allow empty strings as well
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🚨 [#4927] Add missing allow_blank=True for several fields
983192f
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🔊 [#4927] System check for missing allow_blank on non-required charfi…
2259a2b 
…elds

because in most cases it is desired to allow empty strings as well
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🚨 [#4927] Add missing allow_blank=True for several fields
f7e0af3
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🔊 [#4927] System check for missing allow_blank on non-required charfi…
69224ae 
…elds

because in most cases it is desired to allow empty strings as well
stevenbal added a commit that referenced this issue Jan 14, 2025
@stevenbal
🚨 [#4927] Add missing allow_blank=True for several fields
ecea971
sergei-maertens added a commit that referenced this issue Jan 14, 2025
@sergei-maertens
Merge pull request #4989 from open-formulieren/feature/4927-serialize…
95b628e 
…r-allow-blank-system-check

🔊 [#4927] Add system check for missing allow_blank on non-required charfields
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbal stevenbal

Labels
enhancement owner: maykin
Projects
Development
Status: Done
Milestone
Release 3.1.0
3 participants
@sergei-maertens @stevenbal @vaszig