Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Forms 3.0 test plan #4978

Closed
7 of 10 tasks
sergei-maertens opened this issue Dec 31, 2024 · 2 comments · Fixed by #4985, #4987 or #4988
Closed
7 of 10 tasks

Open Forms 3.0 test plan #4978

sergei-maertens opened this issue Dec 31, 2024 · 2 comments · Fixed by #4985, #4987 or #4988
Assignees
@joeribekker @sergei-maertens @viktorvanwijk @LaurensBurger
Labels
release Pull Request for a new release.
Milestone
Release 3.0

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented Dec 31, 2024 •
edited by viktorvanwijk
Loading

The following topics/big features still need to be manually tested/verified that everything is in order, meaning:

  • it works
  • it's clear how to use it (UI is sufficiently intuitive)
  • documentation is present to clarify/support where needed

Features to test

  • Product prefill from objects API + update the referenced object during registration (@sergei-maertens )
  • Forms with cosign
    • Flow with direct links in emails
    • Flow without links in emails
  • Submission/product price dynamically calculated with logic (removal of price logic rules) (@viktorvanwijk)
  • Payment plugin, Ogone specify custom COM/TITLE parameters
  • Using alternative map tile layer (@sergei-maertens)
  • Forms with submission limits (@sergei-maertens)
  • Export submission statistics (@viktorvanwijk)
  • Provision instance with setup-configuration artifacts
  • UX improvements in registration/prefill plugin configuration options, in particular ZGW and Objects API
  • Select a product from zaaktype
@sergei-maertens sergei-maertens added the release Pull Request for a new release. label Dec 31, 2024
@sergei-maertens sergei-maertens added this to the Release 3.0 milestone Dec 31, 2024
@sergei-maertens sergei-maertens moved this from Todo to In Progress in Development Dec 31, 2024
@LaurensBurger

This comment was marked as resolved.

Sign in to view
@LaurensBurger

This comment has been minimized.

Sign in to view
sergei-maertens added a commit that referenced this issue Jan 6, 2025
@sergei-maertens
🗑️ [#4978] Make v2 Objects API config the default
3a1b5b7 
This is the first step towards deprecating/removing the template based
configuration. Users now see the v2 configuration as default/first
configuration option.
@sergei-maertens sergei-maertens mentioned this issue Jan 6, 2025
Merged
10 tasks
sergei-maertens added a commit that referenced this issue Jan 6, 2025
@sergei-maertens
🐛 [#4978] Fix accidental HTML escaping in summary PDF/confirmation email
f36da6f 
While the component/formatter properly takes care of conditional
escaping by leveraging format_html and friends, the post-processor
was converting the SafeString into a regular string again by doing
string-interpolation for the file names, which leads to the full
result being HTML escaped again.

In HTML mode, the prefix 'attachment' is now dropped, as the markup and
context of the label/field should provide sufficient information and
the 'attachment:' prefix looks odd in combination with the <ul> markup.
@sergei-maertens sergei-maertens mentioned this issue Jan 6, 2025
Merged
10 tasks
sergei-maertens added a commit that referenced this issue Jan 6, 2025
@sergei-maertens
Merge pull request #4985 from open-formulieren/issue/4978-make-object…
c375347 
…s-v2-config-default

🗑️ [#4978] Make v2 Objects API config the default
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Development Jan 6, 2025
sergei-maertens added a commit that referenced this issue Jan 6, 2025
@sergei-maertens
🧪 [#4978] Add regression test for incorrect geometry summary
280aeb0
sergei-maertens added a commit that referenced this issue Jan 6, 2025
@sergei-maertens
🐛 [#4978] Only mark variable as geometry if the key is not empty
0c3da88 
The empty string as key for a variable incorrectly marked a variable
as geometry variable because the empty values match. Now we only
consider non-empty values as valid, as a variable *must* have a
non-empty key to be valid and mappable.
@sergei-maertens sergei-maertens mentioned this issue Jan 6, 2025
Merged
10 tasks
sergei-maertens added a commit that referenced this issue Jan 6, 2025
@sergei-maertens
Merge pull request #4987 from open-formulieren/issue/4978-fix-escaped…
933bc44 
…-html-in-pdf

🐛 [#4978] Fix accidental HTML escaping in summary PDF/confirmatio…
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeribekker joeribekker

@sergei-maertens sergei-maertens

@viktorvanwijk viktorvanwijk

@LaurensBurger LaurensBurger

Labels
release Pull Request for a new release.
Projects
Development
Status: Done
Milestone
Release 3.0
4 participants
@joeribekker @sergei-maertens @viktorvanwijk @LaurensBurger