[DRAFT] ✨ Implement necessary attributes for DigiD machtigen #1009

stevenbal · 2021-11-30T14:17:23Z

On hold until refactor that introduces SubmissionAuth is done (most likely in not until 2022)

TODO:

Also implement for eHerkenning
Add tests

codecov-commenter · 2021-11-30T14:31:10Z

Codecov Report

Merging #1009 (ecc2d3b) into feature/oidc-for-citizens (8a8c4eb) will decrease coverage by 0.08%.
The diff coverage is 46.66%.

@@                      Coverage Diff                      @@
##           feature/oidc-for-citizens    #1009      +/-   ##
=============================================================
- Coverage                      88.60%   88.52%   -0.09%     
=============================================================
  Files                            404      404              
  Lines                          11027    11007      -20     
  Branches                         991      991              
=============================================================
- Hits                            9771     9744      -27     
- Misses                          1052     1058       +6     
- Partials                         204      205       +1

Impacted Files	Coverage Δ
...enforms/authentication/contrib/digid_oidc/admin.py	`100.00% <ø> (ø)`
...orms/authentication/contrib/digid_oidc/backends.py	`48.71% <0.00%> (-4.06%)`	⬇️
src/openforms/submissions/api/viewsets.py	`95.03% <42.85%> (-2.75%)`	⬇️
src/openforms/authentication/constants.py	`100.00% <100.00%> (ø)`
...nforms/authentication/contrib/digid_oidc/models.py	`85.29% <100.00%> (+0.44%)`	⬆️
src/openforms/submissions/models.py	`95.88% <100.00%> (+0.01%)`	⬆️
src/openforms/forms/api/serializers.py	`92.96% <0.00%> (-0.17%)`	⬇️
...issions/tests/form_logic/test_modify_components.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a8c4eb...ecc2d3b. Read the comment docs.

sergei-maertens · 2021-12-02T12:06:07Z

Please park this entire PR until #957 and #977 are done, we are changing the authentication implementation details.

Note also the final remarks in this comment:

To do later, refactor and decoupling auth module:

Create model SubmissionAuth with fields plugin_id, attribute and value.
This is a generic model suitable for all authentication backends, and should be
part of the base auth plugin.

Store the ID of the SubmissionAuth record in the form_auth session key.

On submission start, correlated the session["form_auth"] to the submission record
(OneToOneField).

Effectively, this should make it possible to store implementation details and functionality with the plugin rather than requiring the Submission model to gain extra fields.

issue: #565

issue #565

to ensure that these auth backends cannot be disabled if they are used for any Forms

since this code is now part of mozilla-django-oidc-db

this is a Keycloak specific feature, that allows OIDC for eHerkenning/DigiD to be configured in such a way that the parameter `kc_idp_hint` is passed to Keycloak when starting the authentication process, allowing Keycloak to automatically forward the user to the intended identity provider (without showing the generic Keycloak login screen/options)

removed the `via OpenID Connect` part, since this information is not useful for end users

stevenbal · 2022-05-10T11:38:19Z

closed in favor of #1485

stevenbal changed the title ~~✨ Implement necessary attributes for DigiD machtigen~~ [DRAFT] ✨ Implement necessary attributes for DigiD machtigen Nov 30, 2021

stevenbal marked this pull request as draft November 30, 2021 14:23

stevenbal force-pushed the feature/digid-machtigen branch from b0c2e18 to ecc2d3b Compare November 30, 2021 14:29

stevenbal added 20 commits December 6, 2021 15:13

✨ Add auth plugin for DigiD login via OIDC

26bed2b

issue: #565

✨ Add auth plugin for eHerkenning login via OIDC

0730c7d

issue #565

✨ Allow disabling of auth plugins

5df408e

✅ Add tests for DigiD/eHerkenning OIDC auth plugins

87159e2

♻️ Configurable kvk/bsn claim name for digid/eherkenning OIDC

fc6a4e2

🍱 Add OIDC configs for DigiD/eHerkenning to admin index

764bbd8

🐛 Workaround for migration dependencies in OAS generation

311074a

✨ Implement logout for DigiD/eHerkenning via OIDC

5cfb277

✅ Fix tests for form oidc auth backend in admin

24cafd5

✨ Add validator for DigiD/eHerkenning disabling via admin

4239d17

to ensure that these auth backends cannot be disabled if they are used for any Forms

✅ Add tests for disabling eHerkenning/DigiD OIDC via admin

decca68

♻️ Remove duplicated code in OIDC admin forms

e3a805e

since this code is now part of mozilla-django-oidc-db

👌 PR feedback

989c006

📝 Add documentation for DigiD/eHerkenning via OIDC

8e35dc9

✨ Add oidc_redirect_allowed_hosts option to OIDC configuration

d57d608

✅ Add tests for allowed/disallowed OIDC redirect domains

dca8e84

✅ Add tests for OIDC keycloak identity provider hint

7005fa9

💄 Shorten OIDC login button labels

8953b3a

removed the `via OpenID Connect` part, since this information is not useful for end users

⬆️ Bump mozilla-django-oidc-db to 0.7.1

0669192

stevenbal force-pushed the feature/oidc-for-citizens branch from 8a8c4eb to 0669192 Compare December 6, 2021 14:36

✨ Implement necessary attributes for DigiD machtigen

5a80cb7

stevenbal force-pushed the feature/digid-machtigen branch from ecc2d3b to 5a80cb7 Compare December 6, 2021 15:35

stevenbal force-pushed the feature/oidc-for-citizens branch 2 times, most recently from b25cd29 to b9e5283 Compare December 14, 2021 12:04

stevenbal force-pushed the feature/oidc-for-citizens branch 3 times, most recently from 424681b to 41dd89f Compare December 20, 2021 13:57

stevenbal force-pushed the feature/oidc-for-citizens branch from 41dd89f to b650007 Compare January 3, 2022 14:14

stevenbal force-pushed the feature/oidc-for-citizens branch 6 times, most recently from a78c9eb to aab0350 Compare January 18, 2022 07:58

stevenbal force-pushed the feature/oidc-for-citizens branch from aab0350 to 4af6662 Compare January 24, 2022 10:39

stevenbal force-pushed the feature/oidc-for-citizens branch 2 times, most recently from 3fb0eac to f73dbe2 Compare February 7, 2022 10:42

stevenbal force-pushed the feature/oidc-for-citizens branch from f1d9a78 to 5d385e1 Compare February 14, 2022 11:57

stevenbal force-pushed the feature/oidc-for-citizens branch 7 times, most recently from 1a0c9d5 to e9069c1 Compare March 4, 2022 15:22

stevenbal force-pushed the feature/oidc-for-citizens branch 4 times, most recently from d5c2b00 to ff227ee Compare March 14, 2022 10:09

Base automatically changed from feature/oidc-for-citizens to master March 14, 2022 10:45

stevenbal closed this May 10, 2022

stevenbal deleted the feature/digid-machtigen branch May 10, 2022 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DRAFT] ✨ Implement necessary attributes for DigiD machtigen #1009

[DRAFT] ✨ Implement necessary attributes for DigiD machtigen #1009

stevenbal commented Nov 30, 2021 •

edited

Loading

codecov-commenter commented Nov 30, 2021 •

edited

Loading

sergei-maertens commented Dec 2, 2021

stevenbal commented May 10, 2022

[DRAFT] ✨ Implement necessary attributes for DigiD machtigen #1009

[DRAFT] ✨ Implement necessary attributes for DigiD machtigen #1009

Conversation

stevenbal commented Nov 30, 2021 • edited Loading

codecov-commenter commented Nov 30, 2021 • edited Loading

Codecov Report

sergei-maertens commented Dec 2, 2021

stevenbal commented May 10, 2022

stevenbal commented Nov 30, 2021 •

edited

Loading

codecov-commenter commented Nov 30, 2021 •

edited

Loading