Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1471] DigiD Machtigen #1485

Merged
merged 9 commits into from
Apr 20, 2022
Merged

[#1471] DigiD Machtigen #1485

merged 9 commits into from
Apr 20, 2022

Conversation

SilviaAmAm
Copy link
Contributor

@SilviaAmAm SilviaAmAm commented Mar 31, 2022

Fixes part of #1471

In this PR the views/plugin/config/backend is kept separate from that of DigiD openID connect. We decided with Steven to do it like this initially because we are not sure if they will have different client ID / secret. If it turns out that more of the DigiD/DigiD Machtigen plugin can be merged then we can do a refactor.

TODO:
At the moment the same endpoints for keycloak are defined in many different places (the main OIDC config page, DigiD OIDC, eHerkenning OIDC page and DigiD machtigen page). Maybe it would be good to refactor the config models.
maykinmedia/mozilla-django-oidc-db#45

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Merging #1485 (281a714) into master (54e360e) will decrease coverage by 0.06%.
The diff coverage is 88.36%.

@@            Coverage Diff             @@
##           master    #1485      +/-   ##
==========================================
- Coverage   92.32%   92.26%   -0.07%     
==========================================
  Files         477      481       +4     
  Lines       14366    14616     +250     
  Branches     1313     1322       +9     
==========================================
+ Hits        13264    13485     +221     
- Misses        852      881      +29     
  Partials      250      250              
Impacted Files Coverage Δ
...b/digid_eherkenning_oidc/tests/digid/test_admin.py 100.00% <ø> (ø)
src/openforms/urls.py 71.42% <ø> (ø)
...ication/contrib/digid_eherkenning_oidc/backends.py 43.58% <29.03%> (-56.42%) ⬇️
src/digid_eherkenning_oidc_generics/backends.py 42.85% <33.33%> (+0.54%) ⬆️
...ntication/contrib/digid_eherkenning_oidc/plugin.py 78.26% <65.00%> (-1.74%) ⬇️
src/digid_eherkenning_oidc_generics/models.py 97.72% <90.00%> (-2.28%) ⬇️
src/digid_eherkenning_oidc_generics/admin.py 100.00% <100.00%> (ø)
...rkenning_oidc_generics/digid_machtigen_settings.py 100.00% <100.00%> (ø)
src/digid_eherkenning_oidc_generics/forms.py 97.14% <100.00%> (+0.47%) ⬆️
src/digid_eherkenning_oidc_generics/mixins.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e360e...281a714. Read the comment docs.

@SilviaAmAm SilviaAmAm force-pushed the feature/digid-machtiging branch 4 times, most recently from 76a3aa0 to 7753b82 Compare April 13, 2022 07:25
@SilviaAmAm SilviaAmAm marked this pull request as ready for review April 13, 2022 09:09
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with the decision to keep config separate and refactor later if we observe a lot of code duplication.

docs/configuration/authentication/oidc_digid_machtigen.rst Outdated Show resolved Hide resolved
docs/configuration/authentication/oidc_digid_machtigen.rst Outdated Show resolved Hide resolved
docs/configuration/authentication/oidc_digid_machtigen.rst Outdated Show resolved Hide resolved
docs/configuration/authentication/oidc_digid_machtigen.rst Outdated Show resolved Hide resolved
docs/configuration/authentication/oidc_digid_machtigen.rst Outdated Show resolved Hide resolved
src/digid_eherkenning_oidc_generics/mixins.py Outdated Show resolved Hide resolved
@SilviaAmAm SilviaAmAm force-pushed the feature/digid-machtiging branch from 7753b82 to 718ef9a Compare April 19, 2022 14:31
@sergei-maertens sergei-maertens merged commit 768c367 into master Apr 20, 2022
@sergei-maertens sergei-maertens deleted the feature/digid-machtiging branch April 20, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants