-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1471] DigiD Machtigen #1485
[#1471] DigiD Machtigen #1485
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1485 +/- ##
==========================================
- Coverage 92.32% 92.26% -0.07%
==========================================
Files 477 481 +4
Lines 14366 14616 +250
Branches 1313 1322 +9
==========================================
+ Hits 13264 13485 +221
- Misses 852 881 +29
Partials 250 250
Continue to review full report at Codecov.
|
76a3aa0
to
7753b82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with the decision to keep config separate and refactor later if we observe a lot of code duplication.
7753b82
to
718ef9a
Compare
Fixes part of #1471
In this PR the views/plugin/config/backend is kept separate from that of DigiD openID connect. We decided with Steven to do it like this initially because we are not sure if they will have different client ID / secret. If it turns out that more of the DigiD/DigiD Machtigen plugin can be merged then we can do a refactor.
TODO:
At the moment the same endpoints for keycloak are defined in many different places (the main OIDC config page, DigiD OIDC, eHerkenning OIDC page and DigiD machtigen page). Maybe it would be good to refactor the config models.
maykinmedia/mozilla-django-oidc-db#45