Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2953] Support date periods #3521

Merged
merged 4 commits into from
Oct 10, 2023
Merged

[#2953] Support date periods #3521

merged 4 commits into from
Oct 10, 2023

Conversation

SilviaAmAm
Copy link
Contributor

@SilviaAmAm SilviaAmAm commented Oct 3, 2023 •
edited
Loading

Fixes #2953

@SilviaAmAm SilviaAmAm marked this pull request as draft October 3, 2023 12:21
@SilviaAmAm SilviaAmAm force-pushed the feature/2953-timedelta branch 2 times, most recently from fc2173f to 5da9bba Compare October 3, 2023 14:49
@SilviaAmAm SilviaAmAm marked this pull request as ready for review October 4, 2023 14:26
@SilviaAmAm SilviaAmAm marked this pull request as draft October 4, 2023 15:05
@SilviaAmAm SilviaAmAm force-pushed the feature/2953-timedelta branch from 9d4447a to 10abc91 Compare October 6, 2023 14:55
@SilviaAmAm SilviaAmAm marked this pull request as ready for review October 6, 2023 14:57
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (87503a8) 95.92% compared to head (10abc91) 95.92%.

❗ Current head 10abc91 differs from pull request most recent head fd0e873. Consider uploading reports for the commit fd0e873 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3521   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         672      672           
  Lines       21532    21532           
  Branches     2481     2481           
=======================================
  Hits        20654    20654           
  Misses        609      609           
  Partials      269      269

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens self-assigned this Oct 10, 2023
@sergei-maertens sergei-maertens self-requested a review October 10, 2023 11:55
sergei-maertens
sergei-maertens approved these changes Oct 10, 2023
View reviewed changes
docs/manual/forms/logic.rst Outdated Show resolved Hide resolved
@SilviaAmAm SilviaAmAm merged commit 253ff8a into master Oct 10, 2023
@SilviaAmAm SilviaAmAm deleted the feature/2953-timedelta branch October 10, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-maertens sergei-maertens sergei-maertens approved these changes

Assignees

@sergei-maertens sergei-maertens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow calculation of days between x and y (timedelta)
2 participants
@SilviaAmAm @sergei-maertens