Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3351] Partner info in family component #3525

Merged
merged 12 commits into from
Oct 6, 2023

Conversation

SilviaAmAm
Copy link
Contributor

@SilviaAmAm SilviaAmAm commented Oct 4, 2023

Fixes #3351

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (464e155) 95.90% compared to head (b7d3287) 95.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3525   +/-   ##
=======================================
  Coverage   95.90%   95.91%           
=======================================
  Files         671      671           
  Lines       21439    21475   +36     
  Branches     2458     2469   +11     
=======================================
+ Hits        20561    20597   +36     
  Misses        609      609           
  Partials      269      269           
Files Coverage Δ
src/openforms/contrib/haal_centraal/clients/brp.py 100.00% <100.00%> (ø)
src/openforms/formio/components/custom.py 88.50% <100.00%> (+0.27%) ⬆️
...rmio/components/np_family_members/haal_centraal.py 100.00% <100.00%> (ø)
...rms/formio/components/np_family_members/stuf_bg.py 92.85% <100.00%> (+3.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm marked this pull request as draft October 5, 2023 09:34
@SilviaAmAm SilviaAmAm force-pushed the feature/3351-partner-info-in-family branch from db475d2 to 78fe7bf Compare October 5, 2023 10:03
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary until we have an actual test response

@SilviaAmAm SilviaAmAm marked this pull request as ready for review October 6, 2023 08:16
docs/manual/forms/form_fields.rst Outdated Show resolved Hide resolved
docs/manual/forms/form_fields.rst Outdated Show resolved Hide resolved
src/openforms/formio/components/custom.py Outdated Show resolved Hide resolved
@SilviaAmAm SilviaAmAm force-pushed the feature/3351-partner-info-in-family branch from 78fe7bf to b7d3287 Compare October 6, 2023 10:01
@SilviaAmAm SilviaAmAm merged commit 248779a into master Oct 6, 2023
@SilviaAmAm SilviaAmAm deleted the feature/3351-partner-info-in-family branch October 6, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve Partner-information from HC and StUF-BG when user is logged in with DigiD
2 participants