-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add the ability to set a form as non applicable by default #3551
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3551 +/- ##
==========================================
- Coverage 95.97% 95.93% -0.04%
==========================================
Files 680 673 -7
Lines 21818 21617 -201
Branches 2515 2492 -23
==========================================
- Hits 20939 20739 -200
Misses 609 609
+ Partials 270 269 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only made it to 12/16 files, I will continue reviewing tomorrow!
Please rebase on master to confirm that the ci failures are resolved, after that you can merge this! |
3430bfa
to
badfe84
Compare
Fixes #2952.
Todo:
Validate that first step is applicable (if not, the submission cannot start).
I think a tooltip (using the-> revertedtitle
HTML attribute) could be interesting to use here (requires an additional prop to ourField
component), besides making it disabled:Should we check if steps are applicable on the Start Page? Currently:
After accessing first step (if Hide non-applicable form steps is set, n/a steps wouldn't even appear):
✨ [open-formulieren/open-forms#2952] Support form steps to be N/A by default open-forms-sdk#575