Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add the ability to set a form as non applicable by default #3551

Merged
merged 10 commits into from
Oct 30, 2023

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Oct 23, 2023

Fixes #2952.

Todo:

  • Validate that first step is applicable (if not, the submission cannot start). I think a tooltip (using the title HTML attribute) could be interesting to use here (requires an additional prop to our Field component), besides making it disabled: -> reverted
    image

  • Should we check if steps are applicable on the Start Page? Currently:
    image
    After accessing first step (if Hide non-applicable form steps is set, n/a steps wouldn't even appear):
    image
    ✨ [open-formulieren/open-forms#2952] Support form steps to be N/A by default open-forms-sdk#575

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b33793f) 95.97% compared to head (8cbfcfb) 95.93%.

❗ Current head 8cbfcfb differs from pull request most recent head badfe84. Consider uploading reports for the commit badfe84 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3551      +/-   ##
==========================================
- Coverage   95.97%   95.93%   -0.04%     
==========================================
  Files         680      673       -7     
  Lines       21818    21617     -201     
  Branches     2515     2492      -23     
==========================================
- Hits        20939    20739     -200     
  Misses        609      609              
+ Partials      270      269       -1     
Files Coverage Δ
src/openforms/forms/api/serializers/form_step.py 100.00% <100.00%> (ø)
.../forms/api/serializers/logic/action_serializers.py 100.00% <ø> (ø)
src/openforms/forms/api/validators.py 95.87% <100.00%> (+0.17%) ⬆️
src/openforms/forms/constants.py 100.00% <100.00%> (ø)
src/openforms/forms/models/form_step.py 100.00% <100.00%> (ø)
...rc/openforms/submissions/models/submission_step.py 92.92% <100.00%> (+0.32%) ⬆️
src/openforms/submissions/logic/actions.py 95.52% <92.85%> (-0.38%) ⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos Viicos changed the title ✨ Add the ability to set a form as non applicable ✨ Add the ability to set a form as non applicable by default Oct 23, 2023
Copy link
Contributor

@SilviaAmAm SilviaAmAm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only made it to 12/16 files, I will continue reviewing tomorrow!

src/openforms/forms/tests/test_models.py Outdated Show resolved Hide resolved
src/openforms/forms/tests/test_models.py Show resolved Hide resolved
src/openforms/js/components/admin/form_design/FormStep.js Outdated Show resolved Hide resolved
src/openforms/forms/models/form_step.py Show resolved Hide resolved
@sergei-maertens
Copy link
Member

Please rebase on master to confirm that the ci failures are resolved, after that you can merge this!

@Viicos Viicos force-pushed the feature/2952-steps-applicable branch 2 times, most recently from 3430bfa to badfe84 Compare October 30, 2023 13:59
@sergei-maertens sergei-maertens merged commit df68b79 into master Oct 30, 2023
25 checks passed
@sergei-maertens sergei-maertens deleted the feature/2952-steps-applicable branch October 30, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow steps to become applicable (reverse n/a)
3 participants