Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump to form builder 0.8.0 #3555

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

sergei-maertens
Copy link
Member

Added support for the component types:

  • date
  • datetime
  • time
  • phoneNumber
  • postcode

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a78870) 95.92% compared to head (05f5061) 95.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3555   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         670      670           
  Lines       21527    21527           
  Branches     2485     2485           
=======================================
  Hits        20649    20649           
  Misses        609      609           
  Partials      269      269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added support for the component types:

* date
* datetime
* time
* phoneNumber
* postcode
@sergei-maertens sergei-maertens force-pushed the feature/bump-experimental-formio-builder branch from 7d7eaf9 to 1539ed5 Compare October 25, 2023 09:16
Thread for reference: jestjs/jest#6229

* Updated jest config to compile packages published as ESM
* Moved babel config from .babelrc to babel.config.js, .babelrc
  is not properly picked anymore in Babel v7 (see linked ref
  above)
@sergei-maertens sergei-maertens force-pushed the feature/bump-experimental-formio-builder branch from 9d0fddc to 05f5061 Compare October 25, 2023 10:44
@vaszig vaszig self-assigned this Oct 27, 2023
@@ -66,6 +66,10 @@
],
"modulePaths": [
"<rootDir>/src/openforms/js"
],
"transformIgnorePatterns": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this added for performance reasons?Do we ignore them because we don't test them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default everything in node_modules is ignored because it's assumed it's already compiled to CommonJS.

However, some libraries ship the modern ESM (EcmaScript Modules) format, and not all tools understand that syntax (the import and export statements in particular).

This rule opts in to compiling packages that you know are not CommonJS yet, so it's kind of the opposite of performance.

@sergei-maertens sergei-maertens merged commit 313cda3 into master Oct 27, 2023
25 checks passed
@sergei-maertens sergei-maertens deleted the feature/bump-experimental-formio-builder branch October 27, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants