Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump to form builder 0.8.0 #3555

Merged
merged 2 commits into from
Oct 27, 2023
Merged

⬆️ Bump to form builder 0.8.0 #3555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1539ed5
:arrow_up: Bump to form builder 0.8.0
sergei-maertens Oct 24, 2023
05f5061
:alien: Ensure jest can handle ES modules
sergei-maertens Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .babelrc
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ WORKDIR /app

# copy configuration/build files
COPY ./build /app/build/
COPY ./*.json ./*.js ./.babelrc /app/
COPY ./*.json ./*.js /app/

# install WITH dev tooling
RUN npm ci --legacy-peer-deps
Expand Down
12 changes: 12 additions & 0 deletions babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
module.exports = {
presets: ['@babel/preset-env', '@babel/react'],
plugins: [
[
'formatjs',
{
idInterpolationPattern: '[sha512:contenthash:base64:6]',
ast: true,
},
],
],
};
40 changes: 19 additions & 21 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"dependencies": {
"@fortawesome/fontawesome-free": "^6.1.1",
"@open-formulieren/design-tokens": "^0.39.0",
"@open-formulieren/formio-builder": "^0.7.2",
"@open-formulieren/formio-builder": "^0.8.0",
"@rjsf/core": "^4.2.1",
"@tinymce/tinymce-react": "^3.12.6",
"@trivago/prettier-plugin-sort-imports": "^4.0.0",
Expand Down Expand Up @@ -66,6 +66,10 @@
],
"modulePaths": [
"<rootDir>/src/openforms/js"
],
"transformIgnorePatterns": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this added for performance reasons?Do we ignore them because we don't test them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default everything in node_modules is ignored because it's assumed it's already compiled to CommonJS.

However, some libraries ship the modern ESM (EcmaScript Modules) format, and not all tools understand that syntax (the import and export statements in particular).

This rule opts in to compiling packages that you know are not CommonJS yet, so it's kind of the opposite of performance.

"/node_modules/(?!@open-formulieren/formio-builder)/",
"\\.pnp\\.[^\\\/]+$"
]
},
"browserslist": [
Expand Down
Loading
Loading