[#3524] Ignore family members without BSN

docs/manual/forms/form_fields.rst

@@ -234,6 +234,7 @@ Gezinsleden
 ===========
 
 De *Gezinsledenscomponent* toont de namen van alle gezinsleden (partners en/of kinderen) als selectievakjes.
+Gezinsleden zonder BSN **worden niet getoond**.
 De waarden die naar de registratie backend worden gestuurd zijn de BSNs.
 
 De gegevens voor de gezinsleden worden opgehaald van Haal Centraal BRP Personen Bevragen of StUF-BG. Dit kan in de Admin

src/openforms/contrib/haal_centraal/clients/brp.py

@@ -83,6 +83,9 @@ def _get_children(self, bsn: str) -> list[Person]:
 
         persons = []
         for kind in response_data["kinderen"]:
+            if "burgerservicenummer" not in kind:
+                continue
+
             name_data = kind["naam"]
             person = Person(
                 bsn=kind["burgerservicenummer"],
@@ -102,6 +105,9 @@ def _get_partner(self, bsn: str) -> list[Person]:
 
         persons = []
         for partner in response_data["partners"]:
+            if "burgerservicenummer" not in partner:
+                continue
+
             name_data = partner["naam"]
             person = Person(
                 bsn=partner["burgerservicenummer"],
@@ -209,6 +215,7 @@ def get_family_members(
                 ),
             )
             for family_member in family_data
+            if "burgerservicenummer" in family_member
         ]
         return family_members
 

src/openforms/contrib/haal_centraal/tests/test_brp_clients.py

@@ -103,6 +103,14 @@ def test_get_kinderen(self):
         self.assertEqual(child.name.voorvoegsel, "")  # type: ignore
         self.assertEqual(child.name.geslachtsnaam, "Kroket")  # type: ignore
 
+    def test_get_kinderen_no_bsn(self):
+        with get_brp_client() as client:
+            children = client.get_family_members(
+                bsn="999990676", include_children=True, include_partner=False
+            )
+
+        self.assertEqual(len(children), 0)  # type: ignore
+
     def test_get_partners(self):
         with get_brp_client() as client:
             partners = client.get_family_members(
@@ -116,6 +124,14 @@ def test_get_partners(self):
         self.assertEqual(partner.name.voorvoegsel, "")  # type: ignore
         self.assertEqual(partner.name.geslachtsnaam, "Kroket")  # type: ignore
 
+    def test_partner_without_bsn(self):
+        with get_brp_client() as client:
+            partners = client.get_family_members(
+                bsn="999990676", include_children=False, include_partner=True
+            )
+
+        self.assertEqual(len(partners), 0)  # type: ignore
+
     def test_get_family_members(self):
         with get_brp_client() as client:
             family_members = client.get_family_members(
@@ -197,6 +213,36 @@ def test_get_kinderen(self):
         )
         super().test_get_kinderen()
 
+    def test_get_kinderen_no_bsn(self):
+        # https://brp-api.github.io/Haal-Centraal-BRP-bevragen/v1/redoc#tag/Ingeschreven-Personen/operation/GetKinderen
+        self.requests_mock.get(
+            "https://personen/api/ingeschrevenpersonen/999990676/kinderen",
+            json={
+                "_links": {
+                    "self": {
+                        "href": "https://personen/api/ingeschrevenpersonen/999990676/kinderen",
+                        "templated": False,
+                        "title": "",
+                    }
+                },
+                "_embedded": {
+                    "kinderen": [
+                        {
+                            "leeftijd": 12,
+                            "naam": {
+                                "geslachtsnaam": "Kroket",
+                                "voorletters": "F.",
+                                "voornamen": "Frieda",
+                                "voorvoegsel": "",
+                            },
+                            "geheimhoudingPersoonsgegevens": True,
+                        }
+                    ],
+                },
+            },
+        )
+        super().test_get_kinderen_no_bsn()
+
     def test_get_partners(self):
         # https://brp-api.github.io/Haal-Centraal-BRP-bevragen/v1/redoc#tag/Ingeschreven-Personen/operation/GetPartners
         self.requests_mock.get(
@@ -226,6 +272,34 @@ def test_get_partners(self):
         )
         super().test_get_partners()
 
+    def test_partner_without_bsn(self):
+        # https://brp-api.github.io/Haal-Centraal-BRP-bevragen/v1/redoc#tag/Ingeschreven-Personen/operation/GetPartners
+        self.requests_mock.get(
+            "https://personen/api/ingeschrevenpersonen/999990676/partners",
+            json={
+                "_links": {
+                    "self": {
+                        "href": "https://personen/api/ingeschrevenpersonen/999990676/partners",
+                        "templated": False,
+                        "title": "",
+                    }
+                },
+                "_embedded": {
+                    "partners": [
+                        {
+                            "naam": {
+                                "geslachtsnaam": "Kroket",
+                                "voorletters": "F.",
+                                "voornamen": "Frieda",
+                                "voorvoegsel": "",
+                            },
+                        }
+                    ],
+                },
+            },
+        )
+        super().test_partner_without_bsn()
+
     def test_get_family_members(self):
         # https://brp-api.github.io/Haal-Centraal-BRP-bevragen/v1/redoc#tag/Ingeschreven-Personen/operation/GetPartners
         self.requests_mock.get(
@@ -337,6 +411,30 @@ def test_get_kinderen(self):
         )
         super().test_get_kinderen()
 
+    def test_get_kinderen_no_bsn(self):
+        # https://brp-api.github.io/Haal-Centraal-BRP-bevragen/v2/redoc#tag/Personen/operation/Personen
+        self.requests_mock.post(
+            "https://personen/api/personen",
+            json={
+                "type": "RaadpleegMetBurgerservicenummer",
+                "personen": [
+                    {
+                        "kinderen": [
+                            {
+                                "naam": {
+                                    "voornamen": "Frieda",
+                                    "voorvoegsel": "",
+                                    "geslachtsnaam": "Kroket",
+                                    "voorletters": "F.",
+                                },
+                            }
+                        ],
+                    }
+                ],
+            },
+        )
+        super().test_get_kinderen_no_bsn()
+
     def test_get_kinderen_person_not_found_results(self):
         # TODO: replace this with VCR and the Docker container of BRP v2
         self.requests_mock.post(
@@ -378,6 +476,29 @@ def test_get_partners(self):
         )
         super().test_get_partners()
 
+    def test_partner_without_bsn(self):
+        # https://brp-api.github.io/Haal-Centraal-BRP-bevragen/v2/redoc#tag/Personen/operation/Personen
+        self.requests_mock.post(
+            "https://personen/api/personen",
+            json={
+                "type": "RaadpleegMetBurgerservicenummer",
+                "personen": [
+                    {
+                        "partners": [
+                            {
+                                "naam": {
+                                    "voornamen": "Jean Marie",
+                                    "geslachtsnaam": "Beaudelaire",
+                                    "voorletters": "J.M.",
+                                }
+                            }
+                        ],
+                    }
+                ],
+            },
+        )
+        super().test_partner_without_bsn()
+
     def test_get_family_members(self):
         # https://brp-api.github.io/Haal-Centraal-BRP-bevragen/v2/redoc#tag/Personen/operation/Personen
         self.requests_mock.post(

src/openforms/js/components/form/np-family-members.js

@@ -55,6 +55,11 @@ class NpFamilyMembers extends SelectBoxes {
       key: 'basic',
       label: 'Basic',
       components: [
+        {
+          type: 'htmlelement',
+          tag: 'div',
+          content: 'Note that any family member without a BSN will not be displayed.',
+        },
         LABEL_REQUIRED,
         KEY,
         DESCRIPTION,

src/openforms/js/lang/formio/nl.json

@@ -395,5 +395,6 @@
   "Translation": "Vertaling",
   "The uploaded file is not of an allowed type. It must be: {{ pattern }}.": "Het geuploaded bestand is niet van een toegestaan type. Het moet {{ pattern }} zijn.",
   "{{ labels }} or {{ lastLabel }}": "{{ labels }} of {{ lastLabel }}",
+  "Note that any family member without a BSN will not be displayed.": "Let op, gezinsleden zonder BSN worden niet getoond.",
   "": ""
 }