Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4158] Add missing English translation for invalid_time #4275

Merged
merged 1 commit into from
May 8, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented May 8, 2024

Also remove unused Dutch translations

Closes #4158

Changes

invalid_time is not defined by Formio, so the missing English translation would result in the bare key being displayed

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Also remove unused Dutch translations
@Viicos
Copy link
Contributor Author

Viicos commented May 8, 2024

Running ./bin/compilemessages_js.sh removes some unrelated translations, should I include this in this PR?

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (1df0654) to head (f888ea9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4275   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         729      729           
  Lines       23491    23491           
  Branches     2757     2757           
=======================================
  Hits        22580    22580           
  Misses        645      645           
  Partials      266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit afe8c2f into master May 8, 2024
27 checks passed
@sergei-maertens sergei-maertens deleted the missing-time-translations branch May 8, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom error messages not picked up for datetime, date and time components
2 participants