Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing search fields and optimization to appointment info admin #4286

Merged
merged 1 commit into from
May 10, 2024

Conversation

sergei-maertens
Copy link
Member

No ticket, I noticed this when I was debugging something and just found out I have a spare branch lying around.

Changes

  • Optimized admin for ApointmentInfo model.
  • Improved being able to find a particular appointment info record with some search fields.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (dfa0d2c) to head (d1769d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4286   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         730      730           
  Lines       23502    23504    +2     
  Branches     2757     2757           
=======================================
+ Hits        22591    22593    +2     
  Misses        645      645           
  Partials      266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit ed48454 into master May 10, 2024
27 checks passed
@sergei-maertens sergei-maertens deleted the feature/appointments-admin branch May 10, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants