Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement backend validation for formio datetime component #4311

Merged
merged 5 commits into from
May 22, 2024

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented May 17, 2024

Partly closes #72

Changes

Added serializer field for min/max datetime validation of formio datetime components.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (9232522) to head (78a017d).
Report is 732 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4311   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         731      731           
  Lines       23684    23716   +32     
  Branches     2789     2795    +6     
=======================================
+ Hits        22799    22831   +32     
  Misses        616      616           
  Partials      269      269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens force-pushed the issue/72-backend-formio-validation-datetime branch from cd0e3dd to 220a55e Compare May 21, 2024 07:13
@sergei-maertens sergei-maertens marked this pull request as ready for review May 21, 2024 07:37
@sergei-maertens sergei-maertens requested a review from vaszig May 21, 2024 07:38
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the merge conflicts looks ok to me.

@sergei-maertens sergei-maertens force-pushed the issue/72-backend-formio-validation-datetime branch from 19b3eda to 58f400b Compare May 22, 2024 08:55
@sergei-maertens sergei-maertens force-pushed the issue/72-backend-formio-validation-datetime branch from 58f400b to 78a017d Compare May 22, 2024 08:58
@sergei-maertens sergei-maertens merged commit fb0c375 into master May 22, 2024
26 of 27 checks passed
@sergei-maertens sergei-maertens deleted the issue/72-backend-formio-validation-datetime branch May 22, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As developer I want to implement frontend and backend validation of form fields
2 participants