Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Simplify variable collection code #4314

Merged
merged 1 commit into from
May 22, 2024

Conversation

sergei-maertens
Copy link
Member

From #4198 final review

@sergei-maertens sergei-maertens requested a review from vaszig May 22, 2024 08:30
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (d2ba32a) to head (61744a7).
Report is 738 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4314      +/-   ##
==========================================
- Coverage   96.24%   96.24%   -0.01%     
==========================================
  Files         731      731              
  Lines       23683    23682       -1     
  Branches     2790     2788       -2     
==========================================
- Hits        22793    22792       -1     
  Misses        622      622              
  Partials      268      268              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sergei-maertens sergei-maertens merged commit 21bbe45 into master May 22, 2024
26 of 27 checks passed
@sergei-maertens sergei-maertens deleted the chore/small-codestyle-improvements branch May 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants