Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update typing-extensions to 4.11.0 #4316

Merged
merged 4 commits into from
May 22, 2024
Merged

⬆️ Update typing-extensions to 4.11.0 #4316

merged 4 commits into from
May 22, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented May 22, 2024

Changes

Apart from here:

def is_str_list(values: list[Any]) -> TypeGuard[list[str]]:
return all(isinstance(value, str) for value in values)

It is safe to use TypeIs for the other cases.

(Separate PR as I'll need it for another one)

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.26%. Comparing base (c38add7) to head (55f40b8).
Report is 727 commits behind head on master.

Files Patch % Lines
src/openforms/config/checks.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4316   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         731      731           
  Lines       23716    23718    +2     
  Branches     2795     2795           
=======================================
+ Hits        22831    22833    +2     
  Misses        616      616           
  Partials      269      269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/openforms/config/checks.py Outdated Show resolved Hide resolved
src/openforms/config/checks.py Outdated Show resolved Hide resolved
src/openforms/config/checks.py Outdated Show resolved Hide resolved
@Viicos Viicos merged commit 9b49cd1 into master May 22, 2024
24 of 27 checks passed
@Viicos Viicos deleted the bump-te branch May 22, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants