Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4298] Broken admin links and certificate label in email digest #4317

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented May 22, 2024

Closes #4298

  • Handle empty labels in certificates
  • Replace admin links with the absolute ones

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (9b49cd1) to head (6181865).
Report is 729 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4317   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         731      731           
  Lines       23718    23723    +5     
  Branches     2795     2795           
=======================================
+ Hits        22833    22838    +5     
  Misses        616      616           
  Partials      269      269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/openforms/emails/digest.py Outdated Show resolved Hide resolved
src/openforms/emails/tests/test_tasks_integration.py Outdated Show resolved Hide resolved
src/openforms/emails/digest.py Outdated Show resolved Hide resolved
src/openforms/emails/digest.py Outdated Show resolved Hide resolved
src/openforms/emails/digest.py Outdated Show resolved Hide resolved
src/openforms/emails/tests/test_tasks_integration.py Outdated Show resolved Hide resolved
@vaszig vaszig force-pushed the fix/4298-certificate-problems-and-admin-urls-not-rendered-properly-in-email-digest branch from 71dec0e to 78603af Compare May 22, 2024 14:03
@vaszig vaszig force-pushed the fix/4298-certificate-problems-and-admin-urls-not-rendered-properly-in-email-digest branch from 78603af to 6181865 Compare May 23, 2024 08:19
@vaszig vaszig requested a review from Viicos May 23, 2024 09:18
@vaszig vaszig merged commit 41375b6 into master May 23, 2024
25 of 27 checks passed
@vaszig vaszig deleted the fix/4298-certificate-problems-and-admin-urls-not-rendered-properly-in-email-digest branch May 23, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificate problems are not rendered properly in email digest
3 participants