Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#72] Backend validation for addressNL component #4326

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented May 24, 2024

Closes #72

Changes

  • Added backend validation for addressNL component

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (9b49cd1) to head (7d57946).
Report is 759 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4326      +/-   ##
==========================================
- Coverage   96.26%   96.26%   -0.01%     
==========================================
  Files         731      731              
  Lines       23718    23756      +38     
  Branches     2795     2801       +6     
==========================================
+ Hits        22833    22868      +35     
- Misses        616      617       +1     
- Partials      269      271       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens requested a review from Viicos May 24, 2024 14:08
src/openforms/formio/tests/validation/helpers.py Outdated Show resolved Hide resolved
src/openforms/formio/tests/validation/test_addressnl.py Outdated Show resolved Hide resolved
src/openforms/formio/tests/validation/test_addressnl.py Outdated Show resolved Hide resolved
src/openforms/formio/components/custom.py Outdated Show resolved Hide resolved
@vaszig vaszig force-pushed the task/72-backend-validation-addressnl-component branch from 92b2a68 to 1e3b816 Compare May 28, 2024 10:47
@vaszig vaszig force-pushed the task/72-backend-validation-addressnl-component branch 2 times, most recently from 76cb94d to 0e252d0 Compare May 30, 2024 09:26
@vaszig vaszig force-pushed the task/72-backend-validation-addressnl-component branch from 0e252d0 to 7d57946 Compare May 30, 2024 09:43
@sergei-maertens sergei-maertens merged commit c1badfa into master May 30, 2024
26 of 28 checks passed
@sergei-maertens sergei-maertens deleted the task/72-backend-validation-addressnl-component branch May 30, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As developer I want to implement frontend and backend validation of form fields
3 participants