Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ [#4255] Speed up PDF generation by replacing flexbox with float #4327

Merged
merged 1 commit into from
May 24, 2024
Merged

⚡ [#4255] Speed up PDF generation by replacing flexbox with float #4327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/openforms/scss/pdfs/_submission-step-row.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
@import '~microscope-sass/lib/typography';

.submission-step-row {
display: flex;
justify-content: flex-start;
align-items: flex-start;

& + & {
margin-top: 1mm;
}
Expand Down Expand Up @@ -42,12 +38,17 @@
@include body();
width: 40%;
padding-right: 2em;
// float is used here, because flexbox/grid/tables are really slow with
// weasyprint, especially if large textareas are used
// see: https://github.com/open-formulieren/open-forms/issues/4255
float: left;
}

&__value {
@include body();
width: 60%;
word-break: break-all;
margin-left: 40%;

// wysiwyg content
p {
Expand Down
Loading