🐛 [#4241] Fix validation of field with nested key in fieldset

[stevenbal]

Closes #4241

Changes

• Fix validation of field with nested key in fieldset

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Problem detection in the admin email digest is handled

• Release management

  • I have labelled the PR as "needs-backport" accordingly

• I have updated the translations assets (you do NOT need to provide translations)

  • Ran ./bin/makemessages_js.sh.sh
  • Ran ./bin/compilemessages_js.sh

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (d9a5bd3) to head (83dd777).
Report is 744 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4329      +/-   ##
==========================================
- Coverage   96.27%   96.25%   -0.02%     
==========================================
  Files         731      731              
  Lines       23735    23741       +6     
  Branches     2797     2800       +3     
==========================================
+ Hits        22850    22853       +3     
- Misses        616      617       +1     
- Partials      269      271       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stevenbal]

@sergei-maertens I do have to add this check here explicitly after I added the editgrid check to is_layout_component

[sergei-maertens]

yeah we shoved editgrid in there in a weird way, I'm glad it's not worse than this

[sergei-maertens]

Can you add a FIXME that this isn't the neatest way to handle this? 😬

[stevenbal]

added it

[stevenbal]

@sergei-maertens I'm not sure why codecov is failing here, if I put a breakpoint after line 99 locally, I see that this case is executed in the openforms.formio tests: https://app.codecov.io/gh/open-formulieren/open-forms/pull/4329/blob/src/openforms/formio/serializers.py

EDIT: nvm, it's the project codecov you mentioned that went down, so it's probably not an issue?

[sergei-maertens]

Backported to 2.6 with 4bf6f06