🗃️ [#4246] Expand AuthInfo model to capture mandate context #4339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4339 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 731 731
Lines 23756 23786 +30
Branches 2801 2803 +2
=======================================
+ Hits 22868 22898 +30
Misses 617 617
Partials 271 271 ☔ View full report in Codecov by Sentry. |
sergei-maertens
force-pushed
the
feature/4246-store-authentication-context-data
branch
from
e66224c to
3366046
Compare
|
For the reviewer, this relates to https://github.com/maykinmedia/authentication-context-schemas |
Viicos
approved these changes
May 31, 2024
Comment on lines
+176
to
+179
| # deprecated! | ||
| machtigen = models.JSONField( | ||
| verbose_name=_("machtigen"), |
There was a problem hiding this comment.
I guess there's no way to extract things from this deprecated fields to set them to the mandate/authorizee fields?
There was a problem hiding this comment.
even worse - the data stored in there is just plain wrong now :)
* Added fields for the (optional) legal subject (authorizee) * Added fields for the (optional) acting subject (authorizee) * Added check constraints to enforce data integrity * Organized the admin in logical groups The authentication context data model identifies two parties: the representee and the authorizee. There is always an authorizee - it *can* be the same actor as the representee if no mandate is in involved. An authorizee has two aspects: legal subject and acting subject. There is always a legal subject. If no acting subject is provided, it is inferred from the legal subject. So, a simple DigiD login in this model is represented by a legal subject authorizee of type BSN. We still keep storing this data in the attribute + value fields, but in the event of a mandate, we will store the additional information for the legal/acting subject.
sergei-maertens
force-pushed
the
feature/4246-store-authentication-context-data
branch
from
3366046 to
ff451e3
Compare
sergei-maertens
deleted the
feature/4246-store-authentication-context-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #4246
Changes
The authentication context data model identifies two parties: the representee and the authorizee. There is always an authorizee - it can be the same actor as the representee if no mandate is in involved.
An authorizee has two aspects: legal subject and acting subject. There is always a legal subject. If no acting subject is provided, it is inferred from the legal subject.
So, a simple DigiD login in this model is represented by a legal subject authorizee of type BSN. We still keep storing this data in the attribute + value fields, but in the event of a mandate, we will store the additional information for the legal/acting subject.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh.sh./bin/compilemessages_js.shCommit hygiene