Upgrade Storybook to v8 #4342
Merged
Upgrade Storybook to v8 #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4342 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 731 731
Lines 23786 23786
Branches 2803 2803
=======================================
Hits 22898 22898
Misses 617 617
Partials 271 271 ☔ View full report in Codecov by Sentry. |
Following the SB v8 upgrade
Mimicking the SDK setup - 1.3 should work fine with SB 8
Looks like there's an issue with picking up the config file, possibly because prettier is also a dependency of storybook. Moving the config to package.json reveals a bunch of code style issues and makes the warnings on the CLI go away.
sergei-maertens
force-pushed
the
chore/upgrade-to-sb8
branch
2 times, most recently
from
25a083b to
f61ba27
Compare
This was probably an implicit default in older SB versions - without it, the existing stories don't render.
We'll run the tests in Chromatic too, but not necessarily on Github actions. This makes it possible to run the tests locally in case there are failures on CI in the future.
* Fixed some missing translations in tests * Fixed missing spies for DMN Action stories * Rewrote existing test to prevent flakiness
sergei-maertens
force-pushed
the
chore/upgrade-to-sb8
branch
from
f61ba27 to
edb82a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #4341
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh.sh./bin/compilemessages_js.shCommit hygiene