Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Objects API sets #4343

Merged
merged 25 commits into from
Jun 20, 2024
Merged

Implement Objects API sets #4343

merged 25 commits into from
Jun 20, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jun 3, 2024 •
edited
Loading

Partly closes #4267, replaces #4332

Changes

[Describe the changes here]

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled

  • Release management

    • I have labelled the PR as "needs-backport" accordingly

  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh.sh
    • Ran ./bin/compilemessages_js.sh

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Viicos added 15 commits May 28, 2024 17:39
@Viicos
[#4267] Remove unused cassettes
385ae36
@Viicos
[#4267] Add ObjectsAPIGroupConfig
86af64b
@Viicos
[#4267] Add migration to migrate existing ObjectsAPIConfig
d071062 
Mostly taken from #3146
@Viicos
[#4267] Remove unused fields from the ObjectsAPIConfig
b04570e
@Viicos
[#4267] Update admin index fixture
d1e1553
@Viicos
[#4267] Register ObjectsAPIGroupConfig in admin
9ea6348
@Viicos
[#4267] Update config checks
9c28999 
Some checks are removed, as they will be added
in the options serializer instead.
@Viicos
[#4267] Update Objecttypes client tests
b68a6b0
@Viicos
[#4267] Update API endpoints related to Objecttypes and objecttypes v…
b4d5653 
…ersions fetching

They now take a new query parameter, specifiying the group to use.
Tests are updated.
@Viicos
[#4267] Add option to select Objects API group in the frontend
2c92099
@Viicos
[#4267] Update Objects API plugin implementation to use Objects API g…
5b28902 
…roups
@Viicos
[#4267] Update Objects API registration tests
acbc6bb
@Viicos
[#4267] Update misc. tests related to config refactor
cbc7749 
It is assumed that the ZGW registration will use the default Objects API.
This is currently not configurable, but will be in the future.
@Viicos
[#4267] Update informatieobjecttypes endpoint
84f76a3 
It now takes a new `objects_api_group` parameter, similar to zgw.
`registration_backend` is now made required, as it doesn't really
make sense to have it optional.

The endpoint also raises a 400 if the query parameters are invalid.

Tests were adapted/refactored.
@Viicos
[#4267] Make JS messages
5862ae7
@Viicos Viicos mentioned this pull request Jun 3, 2024
Closed
@Viicos Viicos force-pushed the feature/4267-objects-api-sets-2 branch from b63f616 to 63df7c4 Compare June 3, 2024 12:21
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.18310% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.49%. Comparing base (67d8ef1) to head (ee57bb7).
Report is 685 commits behind head on master.

Files with missing lines Patch % Lines
...nforms/registrations/contrib/objects_api/config.py 91.30% 1 Missing and 1 partial ⚠️
src/openforms/registrations/api/filters.py 95.00% 0 Missing and 1 partial ⚠️
...nforms/registrations/contrib/objects_api/models.py 93.75% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4343   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files         719      719           
  Lines       23689    23733   +44     
  Branches     2799     2808    +9     
=======================================
+ Hits        22858    22902   +44     
- Misses        562      563    +1     
+ Partials      269      268    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos Viicos force-pushed the feature/4267-objects-api-sets-2 branch 4 times, most recently from 7fd5e66 to 6f19b27 Compare June 17, 2024 17:03
@Viicos Viicos force-pushed the feature/4267-objects-api-sets-2 branch from abaec1f to 511013f Compare June 18, 2024 07:25
@Viicos
Copy link
Contributor Author

Viicos commented Jun 18, 2024

I haven't implemented anything specific regarding the objects api group select (i.e. auto select the first one if there's only one group available). This would require the dropdown select to allow blank which shouldn't really be the case

@Viicos Viicos force-pushed the feature/4267-objects-api-sets-2 branch from b16860d to 9a244d8 Compare June 18, 2024 17:03
@Viicos Viicos force-pushed the feature/4267-objects-api-sets-2 branch 2 times, most recently from c13808f to e8d74ec Compare June 19, 2024 07:55
sergei-maertens
sergei-maertens requested changes Jun 19, 2024
View reviewed changes
...penforms/js/components/admin/form_design/registrations/objectsapi/ObjectTypeVersionSelect.js Outdated Show resolved Hide resolved
...components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.stories.js Outdated Show resolved Hide resolved
src/openforms/js/components/admin/form_design/registrations/objectsapi/utils.js Show resolved Hide resolved
src/openforms/registrations/api/filters.py Show resolved Hide resolved
src/openforms/registrations/api/filters.py Show resolved Hide resolved
src/openforms/registrations/contrib/objects_api/config.py Outdated Show resolved Hide resolved
src/openforms/registrations/contrib/objects_api/config.py Outdated Show resolved Hide resolved
src/openforms/registrations/contrib/objects_api/models.py Show resolved Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_template.py Outdated Show resolved Hide resolved
src/openforms/registrations/contrib/zgw_apis/plugin.py Outdated Show resolved Hide resolved
@Viicos Viicos force-pushed the feature/4267-objects-api-sets-2 branch from f35b750 to 35aa719 Compare June 19, 2024 14:00
@Viicos Viicos force-pushed the feature/4267-objects-api-sets-2 branch from 35aa719 to 4e2374e Compare June 19, 2024 15:41
@sergei-maertens sergei-maertens merged commit e9e2f4e into master Jun 20, 2024
31 checks passed
@sergei-maertens sergei-maertens deleted the feature/4267-objects-api-sets-2 branch June 20, 2024 13:12
@Viicos Viicos mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-maertens sergei-maertens sergei-maertens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying the documents API in the objects API registration
2 participants
@Viicos @sergei-maertens