Change minimum submission removal limit to 0

[robinmolen]

Closes #4815

Changes

Allowing submissions to be deleted after 0 days.

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Problem detection in the admin email digest is handled

• Release management

  • I have labelled the PR as "needs-backport" accordingly

• I have updated the translations assets (you do NOT need to provide translations)

  • Ran ./bin/makemessages_js.sh
  • Ran ./bin/compilemessages_js.sh

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (957b7c1) to head (9e77550).
Report is 5 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4819   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         748      748           
  Lines       25423    25423           
  Branches     3362     3362           
=======================================
  Hits        24548    24548           
  Misses        610      610           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sergei-maertens]

I would like to see a test that creates a submission on timestamp t0 with a form configured to delete submissions after 0 days, and then the delete_submissions is invoked a couple of hours later (e.g. submission create at 18:00 and delete runs at 01:00 AM) to confirm that the submission is then indeed deleted.

I'm seeing some code with the annotations of how old a submission is that I'm not 100% convinced yet this patch fully resolves the problem.

[sergei-maertens]

what's up with the lambda? Is there a reason you can't do:

with freeze_time("2024-11-12T18:00:00+01:00"):

furthermore, never ever use naive datetimes in python/django (yours is naive, because no tzinfo has been specified). Generally you want to use the django wrappers defined in django.utils.timezone.

[robinmolen]

Ah yeah, that lambda isn't needed 👍

Ah okay, check. I'll keep it in mind