Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2177 map interactions and different map data #4953

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robinmolen
Copy link
Contributor

@robinmolen robinmolen commented Dec 18, 2024

Part of #2177

Changes

Changing the datatype of the map component from array to geoJson

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen force-pushed the feature/2177-map-interactions-and-different-map-data branch from 4aaecd1 to 45f8fdc Compare December 18, 2024 16:27
For the map interaction changes, we need to save the map data in a different format. This is to allow us to differentiate between point, line or polygon map information.
@robinmolen robinmolen force-pushed the feature/2177-map-interactions-and-different-map-data branch from 45f8fdc to 9653b84 Compare January 6, 2025 15:13
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.68%. Comparing base (105dcdf) to head (42885c6).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...s/registrations/contrib/objects_api/handlers/v2.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4953      +/-   ##
==========================================
+ Coverage   96.66%   96.68%   +0.02%     
==========================================
  Files         761      761              
  Lines       25957    25993      +36     
  Branches     3393     3393              
==========================================
+ Hits        25091    25132      +41     
+ Misses        601      598       -3     
+ Partials      265      263       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinmolen robinmolen force-pushed the feature/2177-map-interactions-and-different-map-data branch from 9653b84 to 3438a77 Compare January 6, 2025 15:59
@robinmolen robinmolen marked this pull request as ready for review January 6, 2025 15:59
@robinmolen robinmolen force-pushed the feature/2177-map-interactions-and-different-map-data branch 2 times, most recently from 2c1409b to dcee0e7 Compare January 7, 2025 08:37
@robinmolen robinmolen force-pushed the feature/2177-map-interactions-and-different-map-data branch from dcee0e7 to 42885c6 Compare January 7, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kaartmateriaal - Verschillende types kaart-interactie (Point, Polygon en Line)
1 participant