Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eherkenning docs #4960

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Update eherkenning docs #4960

merged 3 commits into from
Dec 27, 2024

Conversation

sergei-maertens
Copy link
Member

Partly closes #4785

The documentation update is independent from the library changes, but it would be great if both are done in one go.

Changes

  • Removed the warnings that configuration in the admin is not possible
  • Added section about CSR generation
  • Updated configuration steps with moved/new fields from django-digid-eherkenning library fields

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@sergei-maertens sergei-maertens force-pushed the issue/4785-eherkenning-docs branch 2 times, most recently from ffaa20a to 8607b8a Compare December 19, 2024 15:53
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (0e095fd) to head (6761812).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4960   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         760      760           
  Lines       25838    25838           
  Branches     3386     3386           
=======================================
  Hits        24965    24965           
  Misses        608      608           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/configuration/authentication/digid.rst Outdated Show resolved Hide resolved
docs/configuration/authentication/digid.rst Outdated Show resolved Hide resolved
docs/configuration/authentication/digid.rst Show resolved Hide resolved
@sergei-maertens sergei-maertens changed the title Issue/4785 eherkenning docs Update eherkenning docs Dec 27, 2024
Updated the outdated sections and added the extra steps/configuration
options now that it is possible to configure things in the admin.

It's mostly the same from the DigiD configuration.
@sergei-maertens sergei-maertens force-pushed the issue/4785-eherkenning-docs branch from 8607b8a to 1fb0e1b Compare December 27, 2024 09:14
This release patches the eHerkenning metadata generation.
@sergei-maertens sergei-maertens merged commit d49defd into master Dec 27, 2024
33 checks passed
@sergei-maertens sergei-maertens deleted the issue/4785-eherkenning-docs branch December 27, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feedback Signicat/kpn on generated eHerkenning metadata.xml
2 participants