.msg file upload #4961
Merged
.msg file upload #4961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The removal of the |
robinmolen
force-pushed
the
bug/4795-msg-file-upload
branch
from
6833a2c to
4908172
Compare
|
The |
robinmolen
force-pushed
the
bug/4795-msg-file-upload
branch
from
4908172 to
2d11d04
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4961 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 761 761
Lines 25904 25908 +4
Branches 3385 3386 +1
=======================================
+ Hits 25036 25040 +4
Misses 604 604
Partials 264 264 ☔ View full report in Codecov by Sentry. |
robinmolen
force-pushed
the
bug/4795-msg-file-upload
branch
2 times, most recently
from
cc51188 to
5e77364
Compare
sergei-maertens
force-pushed
the
bug/4795-msg-file-upload
branch
from
5e77364 to
061dce1
Compare
sergei-maertens
requested changes
Dec 27, 2024
There was a problem hiding this comment.
Can you please exclude backend translations from PRs? They get sorted out during the release preparation.
They're a frequent source of merge conflicts otherwise.
sergei-maertens
force-pushed
the
bug/4795-msg-file-upload
branch
from
061dce1 to
647522e
Compare
sergei-maertens
force-pushed
the
bug/4795-msg-file-upload
branch
2 times, most recently
from
071c30b to
d82f035
Compare
The SDK cannot reliably determine which content type belongs to a .msg file, most notably on Linux and MacOS because the extension is not in the mime type database. This manifests as a file being uploaded with empty content-type. To allow these files to go through, the serializer must allow empty values for the 'type' field which contains the detected content type, and the backend must perform additional processing to determine the file type. We can do this by falling back to the generic case of 'binary file' (application/octet-stream) content type, and let libmagic figure out which extensions belong to the magic bytes, i.e. we look at the magic bytes to figure out what kind of file was provided, and we check the provided file extensions against the list of valid extensions for the detected file type.
The validator now rejects (temporary) file uploads that don't have an extension, as this prevents validating that the extension and content type match. This used to pass and would then be caught later when linking the file upload component and temporary file upload.
sergei-maertens
force-pushed
the
bug/4795-msg-file-upload
branch
from
1ac9576 to
f3bf841
Compare
sergei-maertens
approved these changes
Dec 30, 2024
sergei-maertens
added
the
needs-backport
sergei-maertens
pushed a commit
that referenced
this pull request
Dec 30, 2024
The SDK cannot reliably determine which content type belongs to a .msg file, most notably on Linux and MacOS because the extension is not in the mime type database. This manifests as a file being uploaded with empty content-type. To allow these files to go through, the serializer must allow empty values for the 'type' field which contains the detected content type, and the backend must perform additional processing to determine the file type. We can do this by falling back to the generic case of 'binary file' (application/octet-stream) content type, and let libmagic figure out which extensions belong to the magic bytes, i.e. we look at the magic bytes to figure out what kind of file was provided, and we check the provided file extensions against the list of valid extensions for the detected file type. Backport-of: #4961
sergei-maertens
pushed a commit
that referenced
this pull request
Dec 30, 2024
The SDK cannot reliably determine which content type belongs to a .msg file, most notably on Linux and MacOS because the extension is not in the mime type database. This manifests as a file being uploaded with empty content-type. To allow these files to go through, the serializer must allow empty values for the 'type' field which contains the detected content type, and the backend must perform additional processing to determine the file type. We can do this by falling back to the generic case of 'binary file' (application/octet-stream) content type, and let libmagic figure out which extensions belong to the magic bytes, i.e. we look at the magic bytes to figure out what kind of file was provided, and we check the provided file extensions against the list of valid extensions for the detected file type. Backport-of: #4961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4795
Changes
The sdk cannot determine what content type should be used for .msg files, which results in the content type
"". When you try to submit the form, the fileSerializer doesn't recognizes the content type and returns an error.To allow the submission of .msg files, the content type should be allowed to be empty.
typeproperty onFileSerializeroptionalMimeTypeValidatorChecklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene