Fix bugs in email registraton + objects API prefill combination #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some class names and stylesheets were missing for the inline radio choices, causing the page to look janky.
When an initial data reference is present, a registration plugin must implement the ownership check.
…rence Prefilling some information/variables from the Objects API in combination with email registration is a valid use case, as requested in issue #4650 to keep email addresses private. The ownership check method must be implemented if a submission with non-empty initial_data_reference is being processed - there isn't actually anything to check since registration always sends a new email and there is no inherent update mechanism, so there's also no inherent object ownership.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4977 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 761 761
Lines 25939 25940 +1
Branches 3392 3392
=======================================
+ Hits 25074 25075 +1
Misses 601 601
Partials 264 264 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4650
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene