Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💬 Tailor field help texts to registration/prefill context #4981

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

sergei-maertens
Copy link
Member

Changes

  • Provide help text as prop to component instead of baking it in
  • Tweak labels/help texts

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (f22ab32) to head (3592076).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4981   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files         761      761           
  Lines       25943    25943           
  Branches     3392     3392           
=======================================
  Hits        25078    25078           
  Misses        601      601           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens force-pushed the issue/fix-objects-api-prefill-help-text branch from f7fe83b to 61d59d3 Compare January 2, 2025 11:55
@sergei-maertens sergei-maertens force-pushed the issue/fix-objects-api-prefill-help-text branch from 61d59d3 to 1af6664 Compare January 2, 2025 13:21
This mostly means setting up the appropriate wrappers in Storybook so
that the workarounds from the admin are applied to them... what a
mess.

Let 2025 be the year we can rip out bootstrap.
@sergei-maertens sergei-maertens merged commit d136b35 into master Jan 2, 2025
30 of 31 checks passed
@sergei-maertens sergei-maertens deleted the issue/fix-objects-api-prefill-help-text branch January 2, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant