Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ [#4978] Make v2 Objects API config the default #4985

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

sergei-maertens
Copy link
Member

This is the first step towards deprecating/removing the template based configuration. Users now see the v2 configuration as default/first configuration option.

Closes #4978 (partly)

Changes

  • Swapped around the legacy/variable mappings tab
  • Made the variables (v2) registration the default instead of legacy template based config.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

This is the first step towards deprecating/removing the template based
configuration. Users now see the v2 configuration as default/first
configuration option.
@sergei-maertens sergei-maertens requested a review from vaszig January 6, 2025 13:42
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (7f8fd3b) to head (3a1b5b7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4985      +/-   ##
==========================================
- Coverage   96.66%   96.66%   -0.01%     
==========================================
  Files         761      761              
  Lines       25957    25957              
  Branches     3393     3393              
==========================================
- Hits        25092    25091       -1     
  Misses        601      601              
- Partials      264      265       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, I have accepted the Chromatic changes as well.

@sergei-maertens sergei-maertens merged commit c375347 into master Jan 6, 2025
33 checks passed
@sergei-maertens sergei-maertens deleted the issue/4978-make-objects-v2-config-default branch January 6, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Forms 3.0 test plan
2 participants