🐛 [#4978] Fix accidental HTML escaping in summary PDF/confirmatio… #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the component/formatter properly takes care of conditional escaping by leveraging format_html and friends, the post-processor was converting the SafeString into a regular string again by doing string-interpolation for the file names, which leads to the full result being HTML escaped again. In HTML mode, the prefix 'attachment' is now dropped, as the markup and context of the label/field should provide sufficient information and the 'attachment:' prefix looks odd in combination with the <ul> markup.
|
What it looks like with the patch:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4987 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 761 761
Lines 25957 25959 +2
Branches 3393 3394 +1
=======================================
+ Hits 25092 25094 +2
Misses 601 601
Partials 264 264 ☔ View full report in Codecov by Sentry. |
vaszig
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n email
While the component/formatter properly takes care of conditional escaping by leveraging format_html and friends, the post-processor was converting the SafeString into a regular string again by doing string-interpolation for the file names, which leads to the full result being HTML escaped again.
In HTML mode, the prefix 'attachment' is now dropped, as the markup and context of the label/field should provide sufficient information and the 'attachment:' prefix looks odd in combination with the
markup.-
- Checked copying a form
- Checked import/export of a form
- Config checks in the configuration overview admin page
- Problem detection in the admin email digest is handled
-
- I have labelled the PR as "needs-backport" accordingly
-
- Ran
- Ran
-
- Updated the Dockerfile with the necessary scripts from the
-
- Commit messages refer to the relevant Github issue
- Commit messages explain the "why" of change, not the how
Closes #4978 (partially)
Changes
Fixed accidental double HTML escaping of file component markup.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene